Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update version of xml2js to 0.4.23, fixes #479 #486

Merged
merged 1 commit into from
Nov 2, 2020
Merged

update version of xml2js to 0.4.23, fixes #479 #486

merged 1 commit into from
Nov 2, 2020

Conversation

gugu
Copy link
Contributor

@gugu gugu commented Nov 2, 2020

No description provided.

cjbarth
cjbarth requested changes Nov 2, 2020
View reviewed changes
Copy link
Collaborator

@cjbarth cjbarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-lock.json also needs to be updated.

@cjbarth cjbarth added the semver-patch This change requires at least a semver-patch version bump label Nov 2, 2020
@gugu
Copy link
Contributor Author

gugu commented Nov 2, 2020

No need, it includes the correct version. package-lock.json is not used when passport-saml is used as a dependence

@markstos
Copy link
Contributor

markstos commented Nov 2, 2020

I confirmed that only a top-level package-lock.json is consulted. https://docs.npmjs.com/cli/v6/configuring-npm/package-lock-json

@markstos markstos merged commit 881208b into master Nov 2, 2020
@cjbarth cjbarth deleted the parse-string-promise branch March 15, 2021 18:29
@cjbarth cjbarth mentioned this pull request May 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjbarth cjbarth cjbarth requested changes

Assignees
No one assigned
Labels
semver-patch This change requires at least a semver-patch version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gugu @markstos @cjbarth