fix(typing): multi saml strategy export #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gugu
approved these changes
Nov 19, 2020
cjbarth
added
the
semver-patch
cjbarth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A while ago I added PR #490 which was closed then because of the pending PR with a major Typescript refactor. After installing this refactor I still think the export of the MultiSamlStrategy class isn't complete. This PR adds the (in my opinion) missing export. Without this export, I have to import the MultiSamlStrategy from the deep located file 'passport-saml/lib/passport-saml/multiSamlStrategy' which causes the following TSLint error in my IDE:
With the added export in this PR it is possible to do the import as following: