Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: add @types/xml-encryption #517

Merged
merged 1 commit into from
Dec 21, 2020
Merged

dev: add @types/xml-encryption #517

merged 1 commit into from
Dec 21, 2020

Conversation

midgleyc
Copy link
Contributor

Description

I noticed that you were ignoring errors from xml-encryption not having types. xml-encryption now has types, so those can be used instead.

Checklist:

  • Issue Addressed: [x]
  • Link to SAML spec: [ ]
  • Tests included? [ ]
  • Documentation updated? [ ]

@gugu
Copy link
Contributor

gugu commented Dec 19, 2020

👍

@markstos markstos merged commit 51a154c into node-saml:master Dec 21, 2020
@midgleyc midgleyc deleted the types-xml-encryption branch December 21, 2020 16:03
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Closed
@cjbarth cjbarth mentioned this pull request May 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gugu gugu gugu approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@midgleyc @gugu @markstos