Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating changelog using gren #518

Merged
merged 10 commits into from
Jan 10, 2021
Merged

Generating changelog using gren #518

merged 10 commits into from
Jan 10, 2021

Conversation

gugu
Copy link
Contributor

@gugu gugu commented Jan 7, 2021

@gugu gugu marked this pull request as draft January 7, 2021 15:21
Copy link
Collaborator

@cjbarth cjbarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice. This should speed the process going forward. I see we can even put a badge if we wanted! https://github.com/github-tools/github-release-notes#setup

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
.grenrc.js Show resolved Hide resolved
@gugu
Copy link
Contributor Author

gugu commented Jan 7, 2021

@cjbarth can you please look changelog one more time? Currently, it includes correct changes

CHANGELOG.md Outdated Show resolved Hide resolved
@gugu gugu marked this pull request as ready for review January 7, 2021 16:26
.grenrc.js Outdated Show resolved Hide resolved
@cjbarth
Copy link
Collaborator

cjbarth commented Jan 8, 2021

Final question: is the script in package.json the one that generates this CHANGELOG.md? If not, could you please put the script you use there so that others can duplicate your work later on?

@cjbarth
Copy link
Collaborator

cjbarth commented Jan 8, 2021

I'm not sure what I'm doing wrong then, because even that change you've made isn't working for me. I'm getting the correct tags, but the date is always 1969-12-31 and the message is always "No changelog for this release.". Given that we already have tags: "all" in the config file and -G is the same as --generate, I feel like something else is amiss here. You have this all working properly with npm run changelog?

@cjbarth
Copy link
Collaborator

cjbarth commented Jan 8, 2021

I got it working reliably. I also use prettier on it, as I'd like to roll that out soon as we decide on the async/await thing; I don't want to break the merge too badly by using prettier before then. Feel free to merge this if you are happy with what I've done. Thanks for your hard work on this.

@gugu gugu merged commit dac23a1 into master Jan 10, 2021
@cjbarth cjbarth deleted the changelog branch February 20, 2021 16:31
@cjbarth cjbarth mentioned this pull request May 10, 2021
@cjbarth cjbarth added the chore Refactoring, etc. to keep code-rot in check. label May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactoring, etc. to keep code-rot in check.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants