-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests use typescript #534
Tests use typescript #534
Conversation
I'll review this when the cache code is merged and this is rebased on top of it. |
fe9e5f5
to
1572089
Compare
@cjbarth done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some simple things that need adjustment. I've also prepared some changes and pushed them to clean up the testing framework.
I've merged in the head of |
There are still a few failing test, I think, in part, to the way we are no longer `require`ing `json` files.
There are some tests that fail intermittently, I think because we have a test-interdependence. So, when Mocha runs the tests in random order, some tests occasionally fail. Other than that, I think this code is all better. I would love someone to take a look at the intermittent failures. |
@cjbarth done. PassReqToCallback test modified shared |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good. I think we should probably make a follow-on PR that removes all the deprecated code and converts tests that use deprecated code to use the newer code.
If you feel it looks good, either one of us can do a merge commit (though I would clean up the comment because it is a little crazy now :) ).
Tests switched to ts.