Messed up with a valid response and it still tests as valid. #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I am unsure if this new test shows a bug in the response validation.
For this test I copied the valid response
valid/response.root-signed.assertion-signed.xmland replaced the text "https://evil-corp.com" for "https://hacker-corp.com".I placed this invalid response in
invalid/response.root-invalidly-signed.assertion-signed.xml.This new file should be an invalid response (because I have tempered with the contents).
Therefore the test should result in "Invalid signature", but what it does return is: "SAML assertion expired".
Is this an error, or am I missing something here?
Checklist: