Fix: Conflicting profile properties between profile and attributes #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjbarth
reviewed
May 16, 2021
This attributes are also mounted to profile directly in a non conflicting way.
|
This looks good to me. However, either we need to make this PR only against the node-saml project, or we need to land this PR in both this and that project. |
|
@cjbarth We can add this PR on both the projects. That way it's not directly dependent on node-saml release. |
|
Sounds good to me. As soon as I see a corresponding PR in the node-saml project, we'll land it here. |
|
@cjbarth Added same PR on node-saml repo. node-saml/node-saml#5 |
cjbarth
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
passport-saml/src/passport-saml/saml.ts
Line 1319 in f1a436f
It is currently possible to override some default properties of the
profileobject inprocessValidlySignedAssertionAsyncmethod.This can be done if any property like
Issueris also present in the attribute mapping. The expected behavior here should be that the properties (Issuer,inResponseTo,sessionIndex,nameID,nameIDFormat,nameQualifier,spNameQualifier) will probably already be present in the profile, and in that case they shouldn't be overridden by the same named attribute in attribute mapping.This issue can be handled gracefully by simply skipping the value from attribute mapping or an error can be thrown. This PR handles the issue gracefully.
Checklist: