Remove node-saml code and use an import instead
#612
Conversation
package.json
Outdated
| @@ -51,6 +51,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "debug": "^4.3.1", | |||
| "node-saml": "file:../node-saml", | |||
There was a problem hiding this comment.
this seems to expect a certain folder structure which is fine for local development during the transition but should probably at least be a import from a git hash before the PR lands (and quickly be changed to the actual npm package)
There was a problem hiding this comment.
Absolutely. I wasn't going to land it like this. I wanted to get an NPM package in here; thus the other PR over there. I put this up so you could all see why I made the changes I did over on the node-saml project. If everything else looks good here, I'll adjust this reference as soon as node-saml is released as a package.
|
I think this should be good to merge now that it references a beta version of Landing this will allow me to make a PR for another bug fix with the SLO stuff. |
cjbarth
added
the
breaking-change
This is a removal of all the SAML-specific code from this project and instead importing it from node-saml. There are some changes needed to that repo to support this split, which are tracked here.
The idea is to have no functional changes with this PR as apparent from a consumer via the Passport framework, but there will still be major breaking changes to anyone that may have used the internals of this project for their own SAML purposes. This will be released as a 4.0.0 release when it is ready.