-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document passive option #660
Conversation
Support for passive option in node-saml Re: https://github.com/node-saml/node-saml/blob/master/src/saml.ts#L135
Thanks for adding that documentation. Do you happen to have a reference for the part of the SAML spec that refers to? That feature was added a while ago by someone else. I'd like to refresh my understanding of your description before approving :) |
28.4.5 Indicating a Passive Identity Provider I'll see about something more specific to the SAML 2.0 spec. |
I'm having trouble finding actual documentation on the
|
Here it is on page 49: https://docs.oasis-open.org/security/saml/v2.0/saml-core-2.0-os.pdf
|
README.md
Outdated
@@ -165,6 +165,7 @@ export interface Profile { | |||
- `racComparison`: Requested Authentication Context comparison type. Possible values are 'exact','minimum','maximum','better'. Default is 'exact'. | |||
|
|||
- `forceAuthn`: if set to true, the initial SAML request from the service provider specifies that the IdP should force re-authentication of the user, even if they possess a valid session. | |||
- `passive`: if set to true, the initial SAML request from the service provider specifies that the IdP should prevent visible user interaction if possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the spec, "if possible" isn't true. The spec says the IdP "must not". Is there a different resource where you found that it obeys this less strict implementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the spec, "if possible" isn't true. The spec says the IdP "must not". Is there a different resource where you found that it obeys this less strict implementation?
I can't say I have for SAML. I am happy to change this language.
Thanks for reviewing this and finding the documentation. I have updated the language. I hope this helps. |
Please run |
Ok. |
Thanks @cjbarth |
Description
Document support for passive option in
node-saml
Re: https://github.com/node-saml/node-saml/blob/master/src/saml.ts#L135
Checklist: