Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #696

Merged
merged 7 commits into from
Jun 21, 2022
Merged

Update dependencies #696

merged 7 commits into from
Jun 21, 2022

Conversation

cjbarth
Copy link
Collaborator

@cjbarth cjbarth commented Jun 13, 2022

Description

Simple update of dependencies such that all tests run after the update. There are other dependencies that need to be updated, but would involve code changes too.

@cjbarth cjbarth added the dependencies Pull requests that update a dependency file label Jun 13, 2022
markstos
markstos previously approved these changes Jun 14, 2022
Copy link
Contributor

@markstos markstos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed diff. Looks straightforward.

@markstos
Copy link
Contributor

Hmm, looks like the 14.x build causes an out of memory error. I presume this is caused by one of the new dependency updates. Maybe the responsible project has already figured out they are causing problems and have issued an even newer update?

@cjbarth cjbarth merged commit be4402a into node-saml:master Jun 21, 2022
@cjbarth cjbarth deleted the update-dependencies branch June 21, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants