Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update passport to 0.6.x -- See passport changelog for breaking changes #698

Merged
merged 6 commits into from
Jun 21, 2022

Conversation

alesmenzel
Copy link
Contributor

@alesmenzel alesmenzel commented Jun 17, 2022

Update passport version to 0.6.x - see changelog https://github.com/jaredhanson/passport/blob/1e8f112bd233dbffb1904d4dd2051780d81b0a22/CHANGELOG.md#060---2022-05-20

This change should not break usage with passport 0.5.x since the callback was not needed in that version and just wont be used.

@alesmenzel alesmenzel mentioned this pull request Jun 17, 2022
Closed
@cjbarth
Copy link
Collaborator

cjbarth commented Jun 17, 2022

This change should not break usage with passport 0.5.x since the callback was not needed in that version and just wont be used.

I agree, but the types will break. We actually should probably update the types to indicate that the callback is optional. Are you interested in doing that?

Also, things will behave differently since now there is an async callback. So our code necessarily has to be different.

src/strategy.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@cjbarth cjbarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some commits to reduce code duplication and make things easier to read. If you approve of these changes, please post a comment and then we'll get this landed.

Copy link
Contributor Author

@alesmenzel alesmenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cjbarth cjbarth added breaking-change Not backwards compatible. Requires major version bump. dependencies Pull requests that update a dependency file labels Jun 21, 2022
@cjbarth cjbarth merged commit 2a0311e into node-saml:master Jun 21, 2022
@markstos markstos changed the title Update passport to 0.6.x Update passport to 0.6.x -- See passport changelog for breaking changes Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Not backwards compatible. Requires major version bump. dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants