-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update passport to 0.6.x -- See passport changelog for breaking changes #698
Conversation
I agree, but the types will break. We actually should probably update the types to indicate that the callback is optional. Are you interested in doing that? Also, things will behave differently since now there is an async callback. So our code necessarily has to be different. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed some commits to reduce code duplication and make things easier to read. If you approve of these changes, please post a comment and then we'll get this landed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Update passport version to 0.6.x - see changelog https://github.com/jaredhanson/passport/blob/1e8f112bd233dbffb1904d4dd2051780d81b0a22/CHANGELOG.md#060---2022-05-20
This change should not break usage with passport 0.5.x since the callback was not needed in that version and just wont be used.