Update README to remove an insecure suggestion #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srd90
reviewed
Jun 27, 2022
| @@ -51,12 +51,12 @@ passport.use( | |||
| authnContext: [ | |||
| "http://schemas.microsoft.com/ws/2008/06/identity/authenticationmethod/password", | |||
| ], | |||
| // not sure if this is necessary? | |||
| acceptedClockSkewMs: -1, | |||
There was a problem hiding this comment.
node-saml/node-saml/docs/adfs @ <= v4.0.0-beta.3 has this same insecure example (that same node-saml/node-saml document contains string as value for authnContext).
srd90
reviewed
Jun 27, 2022
| identifierFormat: null, | ||
| // this is configured under the Advanced tab in AD FS relying party | ||
| signatureAlgorithm: "sha256", | ||
| racComparison: "exact", // default to exact RequestedAuthnContext Comparison Type | ||
| // From the metadata document | ||
| audience: "https://adfs.acme_tools.com/FederationMetadata/2007-06/FederationMetadata.xml", |
There was a problem hiding this comment.
This example value would be more clearer if it would equal to value of issuer (with proper comment) because audience defaults to issuer (see node-saml/node-saml#25 (comment)). This example's issuer is "acme_tools_com".
Value and code commet of audience: "https://adfs.acme_tools.com/FederationMetadata/2007-06/FederationMetadata.xml" doesn't "resonate" with anything (or did I miss something?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update README to remove an insecure suggestion.