Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README formatting and to provide clearer explanation of examples #812

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

cjbarth
Copy link
Collaborator

@cjbarth cjbarth commented Nov 15, 2022

Description

The README is a little unclear about how the sample code is supposed to work and it has some formatting issues. This correct both of those problems.

It still remains to remove all the information in this README that is also in the node-saml README. We should be referring people to that README instead of duplicating that here.

@cjbarth cjbarth added the documentation Request for or contribution to documentation label Nov 15, 2022
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #812 (a917e66) into master (43ed346) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #812   +/-   ##
=======================================
  Coverage   65.10%   65.10%           
=======================================
  Files           4        4           
  Lines         149      149           
  Branches       37       37           
=======================================
  Hits           97       97           
  Misses         29       29           
  Partials       23       23           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cjbarth cjbarth merged commit 6eb1eb3 into node-saml:master Nov 15, 2022
@cjbarth cjbarth deleted the update-readme branch November 15, 2022 17:49
@cjbarth cjbarth mentioned this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Request for or contribution to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant