Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a patch proposal for issues regarding to non-exclusive c14n handling bug.
This PR contains README update and corresponding unit test specs.
Issues relating:
#113
#153
Note
It was so painful to write code to be compatible with Node.js 0.10.
Give me a praise... 😫
Optional Suggestion
As you know, there is a quick-patch in
lib/signed-xml.js
as below.I found that there are a lot of signed XML in the world with implicit transforms.
Not limited to "validating windows mobile store signatures", sometimes developers need to guess
and apply those hidden implicit transform.
So I added option to specify such implicit transform like this:
This new option is described in README in my PR.
Then this is a suggestion.
Can we eliminate the workaround code for windows mobile store signature?
I know there will be an breaking impact on current xml-crypto users, but it is healthier to specify such an implicit transform into an option.
Currently, my PR preserves that workaround code. So if you are worried to have impacts on existing users, you can safely ignore my suggestion.
Best regards.