Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add Google Group instructions to onboarding #1192

Merged
merged 2 commits into from
Mar 24, 2022
Merged

doc: add Google Group instructions to onboarding #1192

merged 2 commits into from
Mar 24, 2022

Conversation

mmarchini
Copy link
Contributor

@mmarchini mmarchini commented Mar 23, 2022 •
edited
Loading

Trott
Trott reviewed Mar 23, 2022
View reviewed changes
ONBOARDING.md Outdated Show resolved Hide resolved
mhdawson
mhdawson approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestion.

RaisinTen
RaisinTen approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @Trott's suggestion

@mmarchini @Trott
Update ONBOARDING.md
a37defa 
Co-authored-by: Rich Trott <[email protected]>
@Trott Trott merged commit 8bd41e8 into main Mar 24, 2022
@Trott Trott deleted the google-group branch March 24, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@mhdawson mhdawson mhdawson approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mmarchini @Trott @cjihrig @tniessen @richardlau @mhdawson @RaisinTen