Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

post-build-status-update not working with nodejs/node #1016

Closed
maclover7 opened this issue Nov 27, 2017 · 2 comments
Closed

post-build-status-update not working with nodejs/node #1016

maclover7 opened this issue Nov 27, 2017 · 2 comments
Labels
ci-public incident

Comments

@maclover7
Copy link
Contributor

maclover7 commented Nov 27, 2017 •
edited
Loading

Original issue: nodejs/node#17358

Culprit looks like it's #985, but it's kind of confusing. It seems like the IP addresses are setup correctly, but getting this error in the github-bot logs:

16:19:09.613  WARN bot: Ignoring, not allowed to push Jenkins updates (req_id=22f36a15-bbd7-40b7-b0e1-75306c0d81e7, ip=::ffff:147.75.73.189)

Maybe it's the "::ffff:" that's throwing things off?

cc @phillipj
@maclover7 maclover7 mentioned this issue Nov 27, 2017
Closed
@maclover7
Copy link
Contributor Author

Is happening with the other server as well: 16:19:08.250 WARN bot: Ignoring, not allowed to push Jenkins updates (req_id=7ada38f2-de42-47b9-8746-e582ad53a907, ip=::ffff:147.75.69.113)

phillipj added a commit to phillipj/github-bot that referenced this issue Nov 27, 2017
@phillipj
jenkins: handle IPv4 remote address converted to IPv6
6a910af 
After the Jenkins IP whitelist was activated, the inline PR status
reports for nodejs/node seems to be broken.

Seems like the issue here is that IPv4 remote addresses are converted
to IPv6, which wasn't expected too happen.. Stripping any IPv6 parts
off the remote addresses should make our IPv4 comparisons work as
expected.

Refs nodejs/build#1016
Refs nodejs/build#985
@phillipj phillipj mentioned this issue Nov 27, 2017
Merged
phillipj added a commit to nodejs/github-bot that referenced this issue Nov 27, 2017
@phillipj
jenkins: handle IPv4 remote address converted to IPv6 (#161)
994fec2 
After the Jenkins IP whitelist was activated, the inline PR status
reports for nodejs/node seems to be broken.

Seems like the issue here is that IPv4 remote addresses are converted
to IPv6, which wasn't expected too happen.. Stripping any IPv6 parts
off the remote addresses should make our IPv4 comparisons work as
expected.

Refs nodejs/build#1016
Refs nodejs/build#985
@maclover7
Copy link
Contributor Author

This seems to be working again, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci-public incident
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maclover7