Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container upgrade: Alpine 3.12, OpenSSL 1.1.1g, remove OpenSSL 1.0.2 and FIPS #2364

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jun 23, 2020

Alpine 3.12 doesn't come with a Python 2 option and Node 10 and 12's configure don't seem to like Python 3 so I've added an exclusion to VersionSelectorScript. I've also had to symlink python3 as python in those packages because we still force PYTHON=python in the commit-linux job.

Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(insofar I'm able to judge that)

@richardlau
Copy link
Member

We can also remove openssl 1.0.2 and fips from node-test-commit-linux-containered (we'll need to keep the VersionSelector entries until after we update the job). I can do that, if there are no objections.

@rvagg
Copy link
Member Author

rvagg commented Jun 23, 2020

yep, was going to leave that for a separate job since the order of operations is important, more than happy for you to do it. the old FIPS too while you're there.

@rvagg rvagg merged commit 41d831d into master Jun 24, 2020
@rvagg rvagg deleted the rvagg/container-upgrade branch June 24, 2020 05:00
@richardlau
Copy link
Member

We can also remove openssl 1.0.2 and fips from node-test-commit-linux-containered (we'll need to keep the VersionSelector entries until after we update the job). I can do that, if there are no objections.

I've updated the job.
Test builds:
10.x: https://ci.nodejs.org/job/node-test-commit-linux-containered/20965/
master: https://ci.nodejs.org/job/node-test-commit-linux-containered/20966/

Labels still exist on each of the containered nodes in Jenkins,
i.e.

and the VersionSelectorScript.groovy hasn't been updated. They're relatively harmless (as the job is no longer using them), so no rush to edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants