chore(deps): remove package-lock.json #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [remark-parse](https://github.com/remarkjs/remark) from 10.0.0 to 10.0.1. - [Release notes](https://github.com/remarkjs/remark/releases) - [Changelog](https://github.com/remarkjs/remark/blob/main/changelog.md) - [Commits](https://github.com/remarkjs/remark/compare/[email protected]) --- updated-dependencies: - dependency-name: remark-parse dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [remark-stringify](https://github.com/remarkjs/remark) from 10.0.1 to 10.0.2. - [Release notes](https://github.com/remarkjs/remark/releases) - [Changelog](https://github.com/remarkjs/remark/blob/main/changelog.md) - [Commits](https://github.com/remarkjs/remark/compare/[email protected]@10.0.2) --- updated-dependencies: - dependency-name: remark-stringify dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [remark](https://github.com/remarkjs/remark) from 14.0.1 to 14.0.2. - [Release notes](https://github.com/remarkjs/remark/releases) - [Changelog](https://github.com/remarkjs/remark/blob/main/changelog.md) - [Commits](remarkjs/remark@14.0.1...14.0.2) --- updated-dependencies: - dependency-name: remark dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [tap](https://github.com/tapjs/node-tap) from 15.1.1 to 15.1.2. - [Release notes](https://github.com/tapjs/node-tap/releases) - [Commits](tapjs/tapjs@v15.1.1...v15.1.2) --- updated-dependencies: - dependency-name: tap dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
|
Is there value in keeping a lockfile in this project? It has no effect on consumers who install it and I don't think we clone the repo to run it anywhere? |
rvagg
force-pushed
the
rvagg/package-lock-update
branch
from
abdb958 to
6addbf0
Compare
|
yeah, good point, the intention was probably to keep the deps stable when publishing, but I don't think package-lock gets published, does it? |
|
no, it's completely ignored when we publish. |
|
I usually do this when a package-lock isn't useful: nodejs/node-core-utils@08d3a5f |
|
yeah, I have that in my global config and usually don't have them in my projects |
rvagg
force-pushed
the
rvagg/package-lock-update
branch
from
6addbf0 to
7a3037e
Compare
rvagg
changed the title
|
changed to |
rvagg
force-pushed
the
rvagg/package-lock-update
branch
from
7a3037e to
ee4c864
Compare
|
🎉 This PR is included in version 2.7.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
renawolford6
added a commit
to renawolford6/changelog-maker-javascript
that referenced
this pull request
Nov 9, 2022
### [2.7.4](nodejs/changelog-maker@v2.7.3...v2.7.4) (2021-11-23) ### Trivial Changes * **deps:** remove package-lock.json ([#118](nodejs/changelog-maker#118)) ([a059bc7](nodejs/changelog-maker@a059bc7)) * **no-release:** bump tap from 15.0.10 to 15.1.1 ([#113](nodejs/changelog-maker#113)) ([fcfc5c8](nodejs/changelog-maker@fcfc5c8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the dependabot updates, but also a general remove and update for package-lock.json with the new format.