Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update valgrind investigation #525

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

RafaelGSS
Copy link
Member

It looks like this guide is no longer in the Node.js documentation. So, I've found it in the gitmemory and updated step-4.

@richardlau
Copy link
Member

It looks like this guide is no longer in the Node.js documentation.

It was moved by @mhdawson as part of nodejs/node#41408. It's more of a guide than the other things that were moved, so perhaps it should be moved back to docs/guides in the main repo?

@RafaelGSS
Copy link
Member Author

It looks like this guide is no longer in the Node.js documentation.

It was moved by @mhdawson as part of nodejs/node#41408. It's more of a guide than the other things that were moved, so perhaps it should be moved back to docs/guides in the main repo?

Well, I'm fine in both locations, the idea of this repository is that in the future it will be merged in the main repo (AFAIK)

@mhdawson
Copy link
Member

mhdawson commented Feb 7, 2022

I'd suggest we just leave it where it is and update the link. We can figure out if we want to move the doc when the idea of this repository is that in the future it will be merged in the main repo comes to pass.

@RafaelGSS RafaelGSS merged commit db07e1f into nodejs:main Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants