Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention yarn in the README.md #345

Merged
merged 1 commit into from
Mar 3, 2017
Merged

Mention yarn in the README.md #345

merged 1 commit into from
Mar 3, 2017

Conversation

Starefossen
Copy link
Member

I think we should mention what is installed in the Image. Should we add some links or write some more about the different parts?

@pesho
Copy link
Contributor

pesho commented Mar 1, 2017

Looks good. Maybe skip "pre-compiled", i doesn't make much sense for npm and yarn.

chorrell

This comment was marked as off-topic.

@Starefossen Starefossen force-pushed the docs/mention-yarn branch 2 times, most recently from df184ed to c0e7516 Compare March 2, 2017 09:13
@Starefossen
Copy link
Member Author

Updated 😄

pesho

This comment was marked as off-topic.

pesho

This comment was marked as off-topic.

@LaurentGoderre
Copy link
Member

LaurentGoderre commented Mar 2, 2017

It seems a few builds a failing because of trying to install yarn from npm. Do yo guys think we should open a meta issues with the error that occurs in the title for a few weeks to try and catch people having issues with this? @nodejs/docker

@chorrell
Copy link
Contributor

chorrell commented Mar 2, 2017

I think that would be a good idea. Maybe also mention in the issue why we aren't installing yarn via npm (space efficiency)

@Starefossen
Copy link
Member Author

Starefossen commented Mar 2, 2017

Great suggestion @LaurentGoderre. Also @pesho ++ feel free to just fix the spelling directly to the branch, I will be away from the terminal for the rest of the day.

@Starefossen
Copy link
Member Author

Fixed up last nitpick. Merging 😄

@Starefossen Starefossen merged commit c1299d7 into master Mar 3, 2017
@Starefossen Starefossen deleted the docs/mention-yarn branch March 3, 2017 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants