WIP [Do not merge] - Irp type dynamic modules #29

guybedford · 2019-01-27T19:22:09Z

This branch implements the Dynamic Modules v8 implementation and then builds it into the Node.js usage as DynamicModuleWrap alongside ModuleWrap, which can be used to construct dynamic modules for CJS.

The implementation uses the approach { ...exports, default: exports } as the dynamic module shell for CJS and core modules.

So that this branch is effectively identical to #28, but with import { name } from 'cjs' support :)

Refs: nodejs/modules#180 PR-URL: nodejs#6 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Refs: nodejs/modules#180 PR-URL: nodejs#6 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

PR-URL: nodejs#6 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

PR-URL: nodejs#6 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

PR URL: nodejs#12

jdalton

This proposal requires changes to ECMA262 and buy-in from TC39. At the January TC39 meeting there was no clear endorsement with delegates expressing a range of reservations/concerns.

ljharb · 2019-02-11T00:02:36Z

Note, though, that the pushback wasn't about this approach not being feasible, it was that perhaps the parts of the spec should be removed such that it would allow node to do this on its own, without TC39 buy-in.

jdalton · 2019-02-11T00:41:05Z

@ljharb

There was pushback on multiple fronts.
@guybedford's comment here is a nice summary:

The topic of Dynamic Modules has now been brought to TC39 over 7 times, 5 times for the current dynamic modules specification. In the last meeting there were three separate technical arguments made by four different members as well as the author of the ECMAScript modules specification, against dynamic modules from TC39, all of which are irresolvable without significant refactoring of the entire ECMAScript modules specification.

ljharb · 2019-02-11T02:11:48Z

Perhaps i missed some of them; it’d be great to get a summary. From what i saw, especially given the previous consensus/commitment to accommodate node, the objections were overcomeable.

jdalton · 2019-02-11T02:49:27Z

The pushback I remember combined with notes:

Source Text Modification
- Some didn't want any modifications (to source text module or abstract module records)
- Others didn't like Node-only branching
- Others were concerned with weakening the static guarantees
Throwing on export * from
- Preferred default-only export to named exports with throwing
- Some worried it would cause devs to avoid export * from altogether

guybedford and others added 12 commits January 23, 2019 09:06

esm: remove .json support

dd5263c

Refs: nodejs/modules#180 PR-URL: nodejs#6 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

esm: remove .node support

f5637ff

Refs: nodejs/modules#180 PR-URL: nodejs#6 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

esm: remove .js support

8991c94

Refs: nodejs/modules#180 PR-URL: nodejs#6 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

esm: remove node specifier resolution algorithm

daae2b4

Refs: nodejs/modules#180 PR-URL: nodejs#6 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

doc: document minimal kernel

090b5a4

PR-URL: nodejs#6 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

esm: Remove --loader.

efd926a

PR-URL: nodejs#6 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

esm: Remove --experimental-vm-modules.

d04f598

PR-URL: nodejs#6 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

esm: minimal resolver spec and implementation refinements

acdf4e9

PR URL: nodejs#12

specify import file specifier resolution proposal

8d14c12

irp type implementation

c31bb8e

v8: float dynamic modules patch

16088a4

implement dynamic modules

742dd94

MylesBorins added the modules-agenda label Jan 29, 2019

This was referenced Jan 29, 2019

Irp type implementation #28

Merged

Node.js Foundation Modules Team Meeting 2019-01-30 nodejs/modules#258

Closed

MylesBorins force-pushed the modules-lkgr branch 2 times, most recently from 4095efe to 966f6ce Compare February 6, 2019 17:48

nodejs-ci force-pushed the modules-lkgr branch 4 times, most recently from 6b95256 to 66aebb1 Compare February 10, 2019 09:06

jdalton suggested changes Feb 10, 2019

View reviewed changes

nodejs-ci force-pushed the modules-lkgr branch from 66aebb1 to 5374da9 Compare February 11, 2019 09:06

GeoffreyBooth mentioned this pull request Feb 12, 2019

CommonJS import interoperability decisions nodejs/modules#264

Closed

nodejs-ci force-pushed the modules-lkgr branch 2 times, most recently from 55dcaf8 to 4228797 Compare February 13, 2019 09:06

MylesBorins removed the modules-agenda label Mar 4, 2019

nodejs-ci force-pushed the modules-lkgr branch from 6c03eed to 15daf0a Compare March 5, 2019 09:07

MylesBorins force-pushed the modules-lkgr branch from 15daf0a to 03fb3b1 Compare March 5, 2019 18:43

MylesBorins added the blocked label Mar 6, 2019

nodejs-ci force-pushed the modules-lkgr branch 2 times, most recently from bd5c877 to 0237465 Compare March 7, 2019 09:06

MylesBorins force-pushed the modules-lkgr branch from bec588f to ea59221 Compare March 11, 2019 22:56

nodejs-ci force-pushed the modules-lkgr branch 3 times, most recently from 9301a06 to e721cd2 Compare March 14, 2019 08:10

MylesBorins force-pushed the modules-lkgr branch 2 times, most recently from 484d1fb to 7efc53d Compare March 18, 2019 22:07

nodejs-ci force-pushed the modules-lkgr branch 3 times, most recently from c7fa700 to d69f765 Compare March 21, 2019 08:06

MylesBorins force-pushed the modules-lkgr branch 5 times, most recently from 335d584 to 9a343ce Compare March 21, 2019 19:09

nodejs-ci force-pushed the modules-lkgr branch 3 times, most recently from 3a00b51 to bc101f6 Compare March 24, 2019 08:06

MylesBorins force-pushed the modules-lkgr branch 3 times, most recently from fd5b55a to 3a40599 Compare March 27, 2019 02:42

nodejs-ci force-pushed the modules-lkgr branch from 3a40599 to 6fe40a4 Compare March 27, 2019 08:06

MylesBorins force-pushed the modules-lkgr branch from 6fe40a4 to d9cdfd8 Compare March 27, 2019 18:53

nodejs-ci force-pushed the modules-lkgr branch from d9cdfd8 to 230f1f2 Compare March 28, 2019 08:06

guybedford closed this Jul 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP [Do not merge] - Irp type dynamic modules #29

WIP [Do not merge] - Irp type dynamic modules #29

guybedford commented Jan 27, 2019

jdalton left a comment

ljharb commented Feb 11, 2019 •

edited

Loading

jdalton commented Feb 11, 2019 •

edited

Loading

ljharb commented Feb 11, 2019

jdalton commented Feb 11, 2019

WIP [Do not merge] - Irp type dynamic modules #29

WIP [Do not merge] - Irp type dynamic modules #29

Conversation

guybedford commented Jan 27, 2019

jdalton left a comment

Choose a reason for hiding this comment

ljharb commented Feb 11, 2019 • edited Loading

jdalton commented Feb 11, 2019 • edited Loading

ljharb commented Feb 11, 2019

jdalton commented Feb 11, 2019

ljharb commented Feb 11, 2019 •

edited

Loading

jdalton commented Feb 11, 2019 •

edited

Loading