This repository has been archived by the owner on Nov 6, 2022. It is now read-only.
install/uninstall targets in Makefile #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added install, install-strip and uninstall targets, also made DESTDIR useable.
| @@ -42,6 +42,10 @@ CFLAGS_LIB = $(CFLAGS_FAST) -fPIC | |||
|
|
|||
| LDFLAGS_LIB = $(LDFLAGS) -shared | |||
|
|
|||
| PREFIX = $(DESTDIR)/usr/local | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM, but I bet @bnoordhuis might have something to say. I'm totally dumb in file structure of library installations on unixes. |
| @@ -105,6 +109,21 @@ parsertrace_g: http_parser_g.o contrib/parsertrace.c | |||
| tags: http_parser.c http_parser.h test.c | |||
| ctags $^ | |||
|
|
|||
| install: library | |||
| install -D $(SONAME) $(LIBDIR)/$(SONAME) | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM with suggestions. |
|
Implemented @bnoordhuis suggestions. I otherwise never write actual Makefiles, just got annoyed doing the installation manually. |
|
LGTM |
indutny
pushed a commit
that referenced
this pull request
Mar 16, 2015
Add install, install-strip and uninstall targets, make DESTDIR usable. PR-URL: #228 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
|
Landed in 5d414fc, thank you! |
KjellSchubert
pushed a commit
to KjellSchubert/http-parser
that referenced
this pull request
Apr 18, 2015
Add install, install-strip and uninstall targets, make DESTDIR usable. PR-URL: nodejs#228 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For easier installation as shared library.