constants: add | to list of allowed URL chars

The vertical bar character `|` wasn't ported from http-parser during rewrite. This commit introduces it back. See: https://github.com/nodejs/http-parser/blob/5c17dad400e45c5a442a63f250fff2638d144682/http_parser.c#L275 See: nodejs/node#27584 PR-URL: #24 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
nodejs · May 7, 2019 · ba06644 · ba06644
1 parent 4483adc
commit ba06644
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/src/llhttp/constants.ts b/src/llhttp/constants.ts
@@ -153,7 +153,7 @@ export const STRICT_URL_CHAR: CharList = ([
   ':', ';', '<', '=', '>',
   '@', '[', '\\', ']', '^', '_',
   '`',
-  '{', '}', '~',
+  '{', '|', '}', '~',
 ] as CharList).concat(ALPHANUM);
 
 export const URL_CHAR: CharList = STRICT_URL_CHAR

diff --git a/test/request/uri.md b/test/request/uri.md
@@ -67,6 +67,26 @@ off=51 headers complete method=1 v=1/1 flags=0 content_length=0
 off=51 message complete
 ```
 
+## Query URL with vertical bar character
+
+It should be allowed to have vertical bar symbol in URI: `|`.
+
+See: https://github.com/nodejs/node/issues/27584
+
+<!-- meta={"type": "request"} -->
+```http
+GET /test.cgi?query=| HTTP/1.1
+
+
+```
+
+```log
+off=0 message begin
+off=4 len=17 span[url]="/test.cgi?query=|"
+off=34 headers complete method=1 v=1/1 flags=0 content_length=0
+off=34 message complete
+```
+
 ## `host:port` terminated by a space
 
 <!-- meta={"type": "request"} -->