Skip to content
This repository has been archived by the owner on Sep 2, 2023. It is now read-only.

Governance: "Pull Requests" post Phase 2 upstream #311

Merged
merged 5 commits into from
Apr 24, 2019
Merged

Governance: "Pull Requests" post Phase 2 upstream #311

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1716881
Update pull requests after Phase 2 upstream
Apr 10, 2019
be14b4f
Update GOVERNANCE.md
Apr 10, 2019
acc5982
Fix typos
Apr 10, 2019
bd4dc43
fixup: s/working group/team
MylesBorins Apr 17, 2019
a25c00c
fixup: update pr guidelines
MylesBorins Apr 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions GOVERNANCE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,20 @@ meeting. In both cases the decision must be seconded by a majority of the Team
or else the discussion will continue. Simple majority wins. Only Active
Members participate in a vote.

## Merging PRs into this Repository or nodejs/ecmascript-modules
## Pull Requests

This section does not apply to [the Node.js core repository](https://github.com/nodejs/node).
It only applies to [the Modules repository](https://github.com/nodejs/modules) and
[nodejs/ecmascript-modules](https://github.com/nodejs/ecmascript-modules).
This section details expectations for team members involved in any pull
requests that relate to the group's [scope][modules-team-purpose] and
[implementation work][modules-team-plan].

The following expectations apply to all team members involved in a related pull
requests in [this Repository][nodejs-modules] and
the [nodejs/ecmascript-modules][nodejs-ecmascript-modules] fork. This section does
not apply to [the Node.js core repository](https://github.com/nodejs/node).

These expectations are intended to ensure that all concurrent efforts align
with the overall direction of the group for delivering a cohesive and predictable
user experience for ECMAScript, CommonJS, and other modules supported by Node.js.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's really changing here? From a policy perspective.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The biggest change should be the removal of the moratorium

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I am following… Can you suggest or clarify what I can do here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think anything else needs to be done personally


Pull requests not included under the _special exemptions_ section below must
reach consensus in a meeting in order to be merged into this repository. A pull
Expand Down Expand Up @@ -156,3 +165,12 @@ By making a contribution to this project, I certify that:
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.


<!-- Links -->

[nodejs-modules]: https://github.com/nodejs/modules
[nodejs-core]: https://github.com/nodejs/node
[nodejs-ecmascript-modules]: https://github.com/nodejs/ecmascript-modules
[modules-team-purpose]: ./README.md#purpose
[modules-team-plan]: ./doc/plan-for-new-modules-implementation.md