Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

objectwrap: except InstanceMethod no descriptor function supports symbol as name #279

Closed
DaAitch opened this issue Jun 11, 2018 · 2 comments
Closed

objectwrap: except InstanceMethod no descriptor function supports symbol as name #279

DaAitch opened this issue Jun 11, 2018 · 2 comments

Comments

@DaAitch
Copy link
Contributor

DaAitch commented Jun 11, 2018

At current we cannot define e.g. an accessor for Symbol.toStringTag, because we can only use symbols with InstanceMethod.

I'll provide a pull request for the following implementations + more/different tests:

  • StaticMethod
  • StaticAccessor
  • InstanceAccessor
  • StaticValue
  • InstanceValue
DaAitch pushed a commit to wildoak/node-addon-api that referenced this issue Jun 11, 2018
objectwrap: implement missing descriptor definitions for symbols
2bd929a 
Implements descriptor definitions with symbols for `StaticMethod`,
`StaticAccessor`, `InstanceAccessor`, `StaticValue`, `InstanceValue`.

Ref: nodejs#279
@DaAitch DaAitch mentioned this issue Jun 11, 2018
Closed
mhdawson pushed a commit that referenced this issue Sep 18, 2018
@mhdawson
src: implement missing descriptor defs for symbols
0a00e7c 
Implements descriptor definitions with symbols for `StaticMethod`,
`StaticAccessor`, `InstanceAccessor`, `StaticValue`, `InstanceValue`.

Ref: #279

PR-URL: #280
Refs: #279
Reviewed-By: Michael Dawson <[email protected]>
@DaAitch
Copy link
Contributor Author

DaAitch commented Sep 20, 2018

@mhdawson can be closed with #280 landed

@NickNaso
Copy link
Member

@DaAitch Yes we can close the issue. Thanks for your contribution! 👍

kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this issue Aug 24, 2022
@kevindavies8
src: implement missing descriptor defs for symbols
74e6f8e 
Implements descriptor definitions with symbols for `StaticMethod`,
`StaticAccessor`, `InstanceAccessor`, `StaticValue`, `InstanceValue`.

Ref: nodejs/node-addon-api#279

PR-URL: nodejs/node-addon-api#280
Refs: nodejs/node-addon-api#279
Reviewed-By: Michael Dawson <[email protected]>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this issue Aug 26, 2022
@Marlyfleitas
src: implement missing descriptor defs for symbols
76559a2 
Implements descriptor definitions with symbols for `StaticMethod`,
`StaticAccessor`, `InstanceAccessor`, `StaticValue`, `InstanceValue`.

Ref: nodejs/node-addon-api#279

PR-URL: nodejs/node-addon-api#280
Refs: nodejs/node-addon-api#279
Reviewed-By: Michael Dawson <[email protected]>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this issue Sep 19, 2022
@wroy7860
src: implement missing descriptor defs for symbols
8a10d1b 
Implements descriptor definitions with symbols for `StaticMethod`,
`StaticAccessor`, `InstanceAccessor`, `StaticValue`, `InstanceValue`.

Ref: nodejs/node-addon-api#279

PR-URL: nodejs/node-addon-api#280
Refs: nodejs/node-addon-api#279
Reviewed-By: Michael Dawson <[email protected]>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this issue Aug 11, 2023
src: implement missing descriptor defs for symbols
cdd9bde 
Implements descriptor definitions with symbols for `StaticMethod`,
`StaticAccessor`, `InstanceAccessor`, `StaticValue`, `InstanceValue`.

Ref: nodejs/node-addon-api#279

PR-URL: nodejs/node-addon-api#280
Refs: nodejs/node-addon-api#279
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NickNaso @DaAitch