This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
Sync to nodejs/master (2016-05-20) #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tap skipping output is so prevalent yet obscure in nature that we ought to move it into it's own function in test/common.js PR-URL: nodejs/node#6697 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
regress/regress-crbug-514081 allocates a 2G block of memory and if there are multiple variants running at the same time this can lead to crashes, OOM kills or the OS failing to allocate memory. This patch limits us to running a single variant of the test Fixes: nodejs/node#6340 PR-URL: nodejs/node#6678 Reviewed-By: Ben Noorhduis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
adds 2 new tests for streams3 cork behavior, cork then uncork and cork then end PR-URL: nodejs/node#6493 Reviewed-By: James M Snell <[email protected]>
test-debugger-repl-term had incorrect expected output and so was failing. It was likely dependent on previous bugs in the debugger. The fixture file has been modified so that the output is as expected. PR-URL: nodejs/node#6682 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Ben Noorhduis <[email protected]>
PR-URL: nodejs/node#6684 Ref: nodejs/node#6578 Reviewed-By: Ben Noorhduis <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: nodejs/node#6685 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Ben Noorhduis <[email protected]>
The line number checks in test-debugger-repl-break-in-module were checking for line numbers that exceed the total number of lines in the files that were being inspected. Change the checks to match the actual files. PR-URL: nodejs/node#6686 Reviewed-By: Ben Noorhduis <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Using O_SYNC with O_RDONLY is basically a noop. Closes: nodejs/node#6730 PR-URL: nodejs/node#6732 Reviewed-By: Ben Noorhduis <[email protected]>
Previously, the example was checking for error by strict equality to null. The error could be undefined though which would fail that check. PR-URL: nodejs/node#6660 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Jeremy Whitlock <[email protected]>
I often want to run a test many times to see if a failure can be recreated and I believe this is a common use case. We even have this job in the CI https://ci.nodejs.org/job/node-stress-single-test/configure but often you want to run it on a specific machine. This patch adds the --repeat option so that you can repeat the selected set of tests a number of times. Given existing options in test.py this will allow you to run one or more tests for the number of repeats specified. For example: tools/test.py -j8 --repeat 1000 parallel/test-process-exec-argv runs the test-process-exec-argv test 1000 times, running 8 copies in parallel tools/test.py --repeat 2 would run the entire test suite twice. PR-URL: nodejs/node#6700 Reviewed-By: Ben Noorhduis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]> Reviewed-By: joaocgreis - João Reis <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
`make binary` attempts to auto detect DESTCPU if not set, but was assuming being on an Intel architecture. PR-URL: nodejs/node#6310 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: nodejs/node#5958 Fixes: nodejs/node#5954 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Refs: nodejs/node#6508 PR-URL: nodejs/node#6707 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs/node#6688 Ref: nodejs/node#6578 Reviewed-By: Claudio Rodriguez <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Add the `--preserve-symlinks` flag. This makes the changes added in #5950 conditional. By default the old behavior is used. With the flag set, symlinks are preserved, switching to the new behavior. This should be considered to be a temporary solution until we figure out how to solve the symlinked peer dependency problem in a more general way that does not break everything else. Additional test cases are included. PR-URL: nodejs/node#6537 Reviewed-By: Ben Noordhuis <[email protected]>
Until now, the docs stated that `process.noDeprecation` could be set
at runtime, but before any modules were loaded. That was not true,
because `lib/internal/util.js` was loaded during the process startup
process, so setting the flag at runtime was pointless.
Minimal test case:
process.noDeprecation = true;
process.EventEmitter;
This patch moves checking `process.noDeprecation` to the place where
it was actually used.
PR-URL: nodejs/node#6683
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
The current makefile runs both `cctest` and `build-addons` in parallel under the assumption that both rely on `all`. Unfortunately `build-addons` does not rely on all, and there is an edge case where by it is possible to call `build-addons` while compilation is still happening. This patch takes the simplest route by forcing `build-addons` and `cctest` to run in sequence like the other test targets. This ensures that `build-addons` will never be run during compilation. It would be possible to modify `build-addons` to rely on `all` but it would be a much more aggressive change to the MAKEFILE for a fairly minor perf bump, as cctest is so fast. PR-URL: nodejs/node#6723 Reviewed-By: Ben Noordhuis <[email protected]>
Print test name as (for example) "parallel/test-assert". Tests that are scraped from the addons documentation are all named test.js, making it hard to decipher what test is running when only the filename is printed. Fixes: nodejs/node#6651 PR-URL: nodejs/node#6653 Reviewed-By: James M Snell <[email protected]>
Use `close` event rather than `exit` event to make sure all output has been received before checking assertions. PR-URL: nodejs/node#6728 Fixes: nodejs/node#6722 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Replace `assert.equal()` with `assert.strictEqual()` throughout `addon/make-callback-recurse/test.js`. PR-URL: nodejs/node#6704 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Replace lightly-used services file parsing in favor of confirming one of a small number of allowable values in service name lookup tests. In nodejs/node-v0.x-archive#8047, it was decided that this sort of service file parsing was superior to hardcoding acceptable values, but I'm not convinced: * No guarantee that the host uses /etc/services before, e.g., nscd. * Increases complexity of tests without guaranteeing robustness. I think that simply checking against a small set of expected values may be a better solution. Ideally, there would also be a unit test that used a test double for the appropriate `cares` function and confirms that it is called with the correct parameters, but now we're getting way ahead of ourselves. PR-URL: nodejs/node#6709 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
`/bin/sh` does not exist on Android but `/system/bin/sh` does. PR-URL: nodejs/node#6745 Refs: nodejs/node#6733 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Moved the sidebar to a fixed position and moved the main column to the page's body, which results in back/forward navigation through hash links and search highlight working again. Fixes: nodejs/node#6637 Fixes: nodejs/node#6751 Based on: nodejs/node#5716 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Robert Lindstaedt <[email protected]>
Update the error stack printed in the default callback example in the fs doc, matching the latest lib/fs.js. Truncates the stack to make it easier to update in the future. PR-URL: nodejs/node#6617 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Adjust style in doctool tests to conform with predominant style of the rest of the project. The biggest changes are: * Replace string concatenation with `path.join()` * Remove unnecessary quotes from property names PR-URL: nodejs/node#6719 Reviewed-By: James M Snell <[email protected]>
The custom linting rule for argument alignment in multi-line function calls previously ignored template strings in an effort to avoid false positives. This isn't really necessary. Enforce for template strings and adjust whitespace in three tests to abide. (Insert "The test abides" joke of your choosing here.) PR-URL: nodejs/node#6720 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
PR-URL: nodejs/node#6741 Ref: nodejs/node#6578 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
The debugger needs to be active now before one is allowed to query the list of scripts. Replace the example with one that works without installing a debug event listener first. Fixes: nodejs/node#4862 PR-URL: nodejs/node#6757 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Prevent util.inspect of throwing on date object with invalid date value. It changed to output result of toString method call. PR-URL: nodejs/node#6504 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
`readline.emitKeypressEvents` needs `stream` to be in raw mode. PR-URL: nodejs/node#6628 Fixes: nodejs/node#6626 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
PR-URL: nodejs/node#6590 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
Make sure that `catch-stdout-error` has written data before the destination process exits. Fixes: nodejs/node#6791 PR-URL: nodejs/node#6808 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
In 5d38d54, an additional property in node_config.cc was added whose definition depends on having the local `env` variable declared, which in turn depended on `NODE_HAVE_I18N_SUPPORT` being defined. Moving `env = ...` out of the `#ifdef` block allows building via `./configure --without-intl` again. PR-URL: nodejs/node#6820 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
The test is currently flaky and CI provides no real information because the test times out rather than failing on an assertion. Add logging to gather more information about the failure. Refs: nodejs/node#6754 PR-URL: nodejs/node#6769 Reviewed-By: Colin Ihrig <[email protected]>
Remove port increment by `1337` which appears to sometimes result in a port that is already in use. There is no reason not to use `common.PORT`. PR-URL: nodejs/node#6769 Fixes: nodejs/node#6754 Reviewed-By: Colin Ihrig <[email protected]>
Since I was doing the necessary git archaeology anyway, I took the time to add YAML information to the docs about when `addMembership()` and `dropMembership()` first appeared in their current forms. PR-URL: nodejs/node#6753 Ref: nodejs/node#6578 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
The only tests for `addMembership()` and `dropMembership()` (from the `dgram` module) were in `test/internet` which means they almost never get run. This adds checks in `test/parallel`. PR-URL: nodejs/node#6753 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
On OSX it's possible that the fd is replaced, so use the proper libuv API to get the correct fd. PR-URL: nodejs/node#6753 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs/node#6805 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fix `options` usage on `lib/_http_agent.js` for the Legacy API. Fixes: nodejs/node#5051 PR-URL: nodejs/node#5190 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
Since debugger::Agent's interface is not exported, third party embedders will have linking errors if they call Environment's destructor directly. PR-URL: nodejs/node#3098 Reviewed-By: Ben Noordhuis <[email protected]>
Fixes: nodejs/node#6765 PR-URL: nodejs/node#6809 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This makes it so you can see why the check fails if it does. Typically that sort of thing can happen if you are modifying bootstrapping or `process`. PR-URL: nodejs/node#6786 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Git logs print my full name Robert Jefe Lindstaedt. When I did #6389 I forgot simply forgot it. PR-URL: nodejs/node#6880 Reviewed-By: Ben Noordhuis <[email protected]>
Updates the dns module documentation to include documentation on the resolveNaptr method, and also adds the option NAPTR to the list of valid values for rrtype in dns.resolve(hostname[, rrtype], callback). PR-URL: nodejs/node#6586 Fixes: nodejs/node#6507 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Replace booleans with `common.mustCall()`, migrate from `var` to `const`, and apply minor formatting changes. PR-URL: nodejs/node#6756 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]>
General improvements to vm module documentation PR-URL: nodejs/node#6827 Reviewed-By: Ben Noordhuis <[email protected]>
In preparation for a lint rule to flag `__defineGetter__`, refactor the one remaining instance in the code base. PR-URL: nodejs/node#6774 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs/node#6774 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Refs: nodejs/node#6768
Reduce unnecessarily verbose paragraph to a sentence. PR-URL: nodejs/node#6801 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Commit 2b1c01c ("build: refactor pkg-config for shared libraries") from May 2015 introduced python 2.7-specific code. It mainly affects people building on old RHEL platforms where the system python is 2.6. Seemingly a dying breed because the issue went unnoticed (or at least unreported) for a whole year. Fixes: nodejs/node#6711 PR-URL: nodejs/node#6874 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Robert Jefe Lindstaedt <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
|
//cc : @nodejs/node-chakracore |
| @@ -5,6 +5,12 @@ var spawn = require('child_process').spawn; | |||
|
|
|||
| var script = common.fixturesDir + '/empty.js'; | |||
|
|
|||
| if (common.isChakraEngine) { | |||
| console.log('1..0 # Skipped: This test is disabled for chakra engine ' + | |||
| 'because debugger support is not implemented yet.'); | |||
There was a problem hiding this comment.
This should be aligned with the string from the previous line, right? Does the linter allow this?
There was a problem hiding this comment.
yes, jslint didn't complain about this.
nit: commit message typo, |
|
LGTM |
Sync nodejs/master (2016-05-20) at 62376d9 PR-URL: nodejs#73 Reviewed-By: Jianchun Xu <[email protected]>
Disable debugger unit test from running in node-chakracore. PR-URL: nodejs#73 Reviewed-By: Jianchun Xu <[email protected]>
Recently linebreak-style rule was added in jslint which expects linebreaks to be unix style i.e. `LF` by default. However windows has linebreak `CRLF` (`git config auto.crlf=true`) causing this rule to fail for all `*.js` files present in repo. I have disabled the rule for now and opened nodejs/node#6912 to get the right rule for windows user. PR-URL: nodejs#73 Reviewed-By: Jianchun Xu <[email protected]>
kunalspathak
force-pushed
the
chakracore-next
branch
from
5d69f58 to
8d11795
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
linebreak-stylerule of Jslint is disabled. See nodejs/node#6912 for more details.Affected core subsystem(s)
test, tools
Description of change
Sync to nodejs/master as of (2016-05-20) at 62376d9