fixup: remove side-effects from constructor

nodejs · Dec 24, 2017 · 1d84f1d · 1d84f1d
1 parent fdf0e05
commit 1d84f1d
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/lib/internal/process/next_tick.js b/lib/internal/process/next_tick.js
@@ -140,8 +140,6 @@ function setupNextTick() {
                  triggerAsyncId,
                  this);
       }
-
-      nextTickQueue.push(this);
     }
   }
 
@@ -166,7 +164,8 @@ function setupNextTick() {
           args[i - 1] = arguments[i];
     }
 
-    new TickObject(callback, args, getDefaultTriggerAsyncId());
+    nextTickQueue.push(new TickObject(callback, args,
+                                      getDefaultTriggerAsyncId()));
   }
 
   // `internalNextTick()` will not enqueue any callback when the process is
@@ -194,6 +193,6 @@ function setupNextTick() {
 
     if (triggerAsyncId === null)
       triggerAsyncId = getDefaultTriggerAsyncId();
-    new TickObject(callback, args, triggerAsyncId);
+    nextTickQueue.push(new TickObject(callback, args, triggerAsyncId));
   }
 }