deps: V8: backport 71e8f8bb3c26

Original commit message: [codegen] Move definition of GetRegisterParameter to inline header This fixes compilation of V8 in Node.js with Visual Studio 2019. Without this change, MSVC errors with C3779 (a function that returns 'auto' cannot be used before it is defined) on the `static constexpr auto registers()` method. Bug: v8:11420 Change-Id: Id545199e2cdc10c8560031fb5950ec1171e5d554 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2964095 Commit-Queue: Igor Sheludko <[email protected]> Reviewed-by: Igor Sheludko <[email protected]> Cr-Commit-Position: refs/heads/master@{#75173} Refs: v8/v8@71e8f8b
nodejs · Jun 16, 2021 · 99f95a4 · 99f95a4
1 parent 290056c
commit 99f95a4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/common.gypi b/common.gypi
@@ -36,7 +36,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.8',
+    'v8_embedder_string': '-node.9',
 
     ##### V8 defaults for Node.js #####
 

diff --git a/deps/v8/src/codegen/interface-descriptors-inl.h b/deps/v8/src/codegen/interface-descriptors-inl.h
@@ -176,6 +176,13 @@ StaticCallInterfaceDescriptor<DerivedDescriptor>::GetStackParameterCount() {
          DerivedDescriptor::GetRegisterParameterCount();
 }
 
+// static
+template <typename DerivedDescriptor>
+constexpr Register
+StaticCallInterfaceDescriptor<DerivedDescriptor>::GetRegisterParameter(int i) {
+  return DerivedDescriptor::registers()[i];
+}
+
 // static
 constexpr Register FastNewObjectDescriptor::TargetRegister() {
   return kJSFunctionRegister;

diff --git a/deps/v8/src/codegen/interface-descriptors.h b/deps/v8/src/codegen/interface-descriptors.h
@@ -457,10 +457,7 @@ class StaticCallInterfaceDescriptor : public CallInterfaceDescriptor {
   static constexpr inline int GetRegisterParameterCount();
   static constexpr inline int GetStackParameterCount();
   static constexpr inline Register* GetRegisterData();
-
-  static constexpr inline Register GetRegisterParameter(int i) {
-    return DerivedDescriptor::registers()[i];
-  }
+  static constexpr inline Register GetRegisterParameter(int i);
 
   explicit StaticCallInterfaceDescriptor(CallDescriptors::Key key)
       : CallInterfaceDescriptor(key) {}