fixup! use constexpr/consteval

nodejs · Oct 24, 2024 · b6c912b · b6c912b
1 parent cbbfdc0
commit b6c912b
Showing 1 changed file with 19 additions and 18 deletions.
diff --git a/src/node_url.cc b/src/node_url.cc
@@ -83,31 +83,31 @@ void BindingData::Deserialize(v8::Local<v8::Context> context,
 // @see https://www.ietf.org/rfc/rfc1738.txt 2.2. URL Character Encoding Issues
 constexpr auto lookup_table = []() consteval {
   // Each entry is an array that can hold up to 3 chars + null terminator
-  std::array<std::array<char, 4>, LARGEST_ASCII_CHAR_CODE_TO_ENCODE + 1> result{
-  };
+  std::array<std::array<char, 4>, LARGEST_ASCII_CHAR_CODE_TO_ENCODE + 1>
+      result{};
 
   for (uint8_t i = 0; i <= LARGEST_ASCII_CHAR_CODE_TO_ENCODE; i++) {
     switch (i) {
-      #define ENCODE_CHAR(CHAR, HEX_DIGIT_2, HEX_DIGIT_1) \
-      case CHAR: \
-        result[i] = {{'%', HEX_DIGIT_2, HEX_DIGIT_1, 0}}; \
-        break; \
+#define ENCODE_CHAR(CHAR, HEX_DIGIT_2, HEX_DIGIT_1)                            \
+  case CHAR:                                                                   \
+    result[i] = {{'%', HEX_DIGIT_2, HEX_DIGIT_1, 0}};                          \
+    break;
 
       ENCODE_CHAR('\t', '0', '9')  // '\t' == 0x09
       ENCODE_CHAR('\n', '0', 'A')  // '\n' == 0x0A
       ENCODE_CHAR('\r', '0', 'D')  // '\r' == 0x0D
-      ENCODE_CHAR(' ', '2', '0')  // ' ' == 0x20
-      ENCODE_CHAR('"', '2', '2')  // '"' == 0x22
-      ENCODE_CHAR('#', '2', '3')  // '#' == 0x23
-      ENCODE_CHAR('%', '2', '5')  // '%' == 0x25
-      ENCODE_CHAR('?', '3', 'F')  // '?' == 0x3F
-      ENCODE_CHAR('[', '5', 'B')  // '[' == 0x5B
+      ENCODE_CHAR(' ', '2', '0')   // ' ' == 0x20
+      ENCODE_CHAR('"', '2', '2')   // '"' == 0x22
+      ENCODE_CHAR('#', '2', '3')   // '#' == 0x23
+      ENCODE_CHAR('%', '2', '5')   // '%' == 0x25
+      ENCODE_CHAR('?', '3', 'F')   // '?' == 0x3F
+      ENCODE_CHAR('[', '5', 'B')   // '[' == 0x5B
       ENCODE_CHAR('\\', '5', 'C')  // '\\' == 0x5C
-      ENCODE_CHAR(']', '5', 'D')  // ']' == 0x5D
-      ENCODE_CHAR('^', '5', 'E')  // '^' == 0x5E
-      ENCODE_CHAR('|', '7', 'C')  // '|' == 0x7C
-      ENCODE_CHAR('~', '7', 'E')  // '~' == 0x7E
-      #undef ENCODE_CHAR
+      ENCODE_CHAR(']', '5', 'D')   // ']' == 0x5D
+      ENCODE_CHAR('^', '5', 'E')   // '^' == 0x5E
+      ENCODE_CHAR('|', '7', 'C')   // '|' == 0x7C
+      ENCODE_CHAR('~', '7', 'E')   // '~' == 0x7E
+#undef ENCODE_CHAR
 
       default:
         result[i] = {{static_cast<char>(i), '\0', '\0', '\0'}};
@@ -116,7 +116,8 @@ constexpr auto lookup_table = []() consteval {
   }
 
   return result;
-}();
+}
+();
 
 enum class OS { WINDOWS, POSIX };