Apply suggestions from code review

Co-authored-by: Yagiz Nizipli <[email protected]>
nodejs · Jan 5, 2025 · cfda580 · cfda580
1 parent 665d0f4
commit cfda580
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/util-inl.h b/src/util-inl.h
@@ -181,7 +181,7 @@ inline v8::Local<v8::String> OneByteString(v8::Isolate* isolate,
 }
 
 inline v8::Local<v8::String> OneByteString(v8::Isolate* isolate,
-                                           const std::string_view& str) {
+                                           std::string_view str) {
   return OneByteString(isolate, str.data(), str.size());
 }
 

diff --git a/src/util.h b/src/util.h
@@ -341,7 +341,7 @@ inline v8::Local<v8::String> OneByteString(v8::Isolate* isolate,
                                            int length = -1);
 
 inline v8::Local<v8::String> OneByteString(v8::Isolate* isolate,
-                                           const std::string_view& str);
+                                           std::string_view str);
 
 // Used to be a macro, hence the uppercase name.
 template <int N>