fixup: leverage TrackInlineField

nodejs · Mar 1, 2019 · db9edc1 · db9edc1
1 parent df06cc4
commit db9edc1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/node_worker.h b/src/node_worker.h
@@ -53,6 +53,8 @@ class Worker : public AsyncWrap {
 
   void MemoryInfo(MemoryTracker* tracker) const override {
     tracker->TrackField("parent_port", parent_port_);
+    tracker->TrackInlineField(&thread_stopper_, "thread_stopper_");
+    tracker->TrackInlineField(&on_thread_finished_, "on_thread_finished_");
   }
 
   SET_MEMORY_INFO_NAME(Worker)

diff --git a/test/pummel/test-heapdump-worker.js b/test/pummel/test-heapdump-worker.js
@@ -9,8 +9,8 @@ const worker = new Worker('setInterval(() => {}, 100);', { eval: true });
 validateSnapshotNodes('Node / Worker', [
   {
     children: [
-      { node_name: 'Node / uv_async_t', edge_name: 'thread_exit_async' },
-      { node_name: 'Node / Environment', edge_name: 'env' },
+      { node_name: 'Node / AsyncRequest', edge_name: 'thread_stopper_' },
+      { node_name: 'Node / AsyncRequest', edge_name: 'on_thread_finished_' },
       { node_name: 'Node / MessagePort', edge_name: 'parent_port' },
       { node_name: 'Worker', edge_name: 'wrapped' }
     ]