crypto: fix OpenSSL return code handling

PR-URL: #29489 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Sep 25, 2019 · dd5d944 · dd5d944
1 parent 54f327b
commit dd5d944
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -5215,15 +5215,16 @@ bool PublicKeyCipher::Cipher(Environment* env,
     return false;
 
   if (digest != nullptr) {
-    if (!EVP_PKEY_CTX_set_rsa_oaep_md(ctx.get(), digest))
+    if (EVP_PKEY_CTX_set_rsa_oaep_md(ctx.get(), digest) <= 0)
       return false;
   }
 
   if (oaep_label_len != 0) {
     // OpenSSL takes ownership of the label, so we need to create a copy.
     void* label = OPENSSL_memdup(oaep_label, oaep_label_len);
     CHECK_NOT_NULL(label);
-    if (!EVP_PKEY_CTX_set0_rsa_oaep_label(ctx.get(), label, oaep_label_len)) {
+    if (0 >= EVP_PKEY_CTX_set0_rsa_oaep_label(ctx.get(), label,
+                                              oaep_label_len)) {
       OPENSSL_free(label);
       return false;
     }