Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIX bug in Makefile - find with -not #24634

Closed
rvagg opened this issue Nov 25, 2018 · 3 comments
Closed

AIX bug in Makefile - find with -not #24634

rvagg opened this issue Nov 25, 2018 · 3 comments
Labels
aix Issues and PRs related to the AIX platform. build Issues and PRs related to build files or the CI.

Comments

@rvagg
Copy link
Member

rvagg commented Nov 25, 2018

Noticed this the other day when testing the proposed SKIP_XZ feature. Running make on AIX complains when running make now because there is a find with a -not which is apparently not supported. It was first introduced in eebcb48, which is a year ago. It's not fatal, but it errors when you start make and lint-md won't work properly because of it.

LINT_MD_MISC_FILES := $(shell find $(LINT_MD_TARGETS) -type f \
  -not -path '*node_modules*' -not -path 'test/fixtures/*' -name '*.md') \
  $(LINT_MD_ROOT_DOCS)

The error shows up in every run if you look at the console output, e.g. the latest one right now @ https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix61-ppc64/19164/consoleFull:

15:41:59 + gmake run-ci -j 5
15:41:59 find: 0652-017 -not is not a valid option.
15:41:59 python ./configure --verbose  --dest-cpu=ppc64

Low priority I suppose. Over to the IBM folks.
@rvagg rvagg added build Issues and PRs related to build files or the CI. aix Issues and PRs related to the AIX platform. labels Nov 25, 2018
@rvagg
Copy link
Member Author

rvagg commented Nov 25, 2018

@nodejs/platform-aix

@Trott
Copy link
Member

Trott commented Nov 25, 2018

-not is a synonym for ! I believe, and that should be supported everywhere.

Trott added a commit to Trott/io.js that referenced this issue Nov 25, 2018
@Trott
build: replace -not with ! in find
5b91604 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: nodejs#24634
@Trott Trott mentioned this issue Nov 25, 2018
Closed
2 tasks
@Trott
Copy link
Member

Trott commented Nov 25, 2018

Proposed fix in #24635

targos pushed a commit that referenced this issue Nov 27, 2018
@Trott @targos
build: replace -not with ! in find
059d9c7 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: #24634
PR-URL: #24635
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
rvagg pushed a commit that referenced this issue Nov 28, 2018
@Trott @rvagg
build: replace -not with ! in find
3fa4def 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: #24634
PR-URL: #24635
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
refack pushed a commit to refack/node that referenced this issue Jan 14, 2019
@Trott @refack
build: replace -not with ! in find
edcc4e6 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: nodejs#24634
PR-URL: nodejs#24635
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
BethGriggs pushed a commit that referenced this issue Feb 11, 2019
@Trott @BethGriggs
build: replace -not with ! in find
95a3b3e 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: #24634
PR-URL: #24635
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
rvagg pushed a commit that referenced this issue Feb 28, 2019
@Trott @rvagg
build: replace -not with ! in find
748de6b 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: #24634
PR-URL: #24635
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
aix Issues and PRs related to the AIX platform. build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: replace -not with ! in find Trott/io.js
2 participants
@rvagg @Trott