Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: 'Eterm' → 'eterm' in getColorDepth #26077

Closed
sttk opened this issue Feb 13, 2019 · 3 comments
Closed

Bug: 'Eterm' → 'eterm' in getColorDepth #26077

sttk opened this issue Feb 13, 2019 · 3 comments
Labels
good first issue Issues that are suitable for first-time contributors. tty Issues and PRs related to the tty subsystem.

Comments

@sttk
Copy link

sttk commented Feb 13, 2019

I found a bug of getColorDepth at this line.
Elements of TERM_ENVS should be lower case because they are compared with lower case of env.TERM.
@hiroppy hiroppy added the tty Issues and PRs related to the tty subsystem. label Feb 13, 2019
@ofrobots
Copy link
Contributor

@sttk do you want to try opening a pull-request for this? You can find a contribution guide here.

@ofrobots ofrobots added the good first issue Issues that are suitable for first-time contributors. label Feb 13, 2019
@Dlewis89
Copy link

I would like to take a shot at this if sttk doesnt want too.

@sttk
Copy link
Author

sttk commented Feb 14, 2019

@Dlewis89 OK. I ask you this pr.

abshek added a commit to abshek/node that referenced this issue Feb 15, 2019
@abshek
lib: converted element to lowercase in tty.js
543fdfd 
Converted the first element "Eterm" in TERM_ENVS array to "eterm"

Fixes: nodejs#26077
@abshek abshek mentioned this issue Feb 15, 2019
Closed
2 tasks
@danbev danbev closed this as completed in 17820ec Feb 19, 2019
addaleax pushed a commit that referenced this issue Feb 19, 2019
@abshek @addaleax
lib: converted element to lowercase in tty.js
faa1f3d 
Converted the first element "Eterm" in TERM_ENVS array to "eterm"

PR-URL: #26121
Fixes: #26077
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
rvagg pushed a commit that referenced this issue Feb 28, 2019
@abshek @rvagg
lib: converted element to lowercase in tty.js
bf61050 
Converted the first element "Eterm" in TERM_ENVS array to "eterm"

PR-URL: #26121
Fixes: #26077
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are suitable for first-time contributors. tty Issues and PRs related to the tty subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lib: converted element to lowercase in tty.js abshek/node
4 participants
@ofrobots @hiroppy @sttk @Dlewis89