Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIX: test-vm-sigint-existing-handler failing #7981

Closed
mhdawson opened this issue Aug 4, 2016 · 3 comments
Closed

AIX: test-vm-sigint-existing-handler failing #7981

mhdawson opened this issue Aug 4, 2016 · 3 comments
Assignees
@addaleax
Labels
test Issues and PRs related to the tests. vm Issues and PRs related to the vm subsystem.

Comments

@mhdawson
Copy link
Member

mhdawson commented Aug 4, 2016

  • Version: Master
  • Platform: AIX
  • Subsystem: core

While running latest tests on AIX have noticed some processes that remain running after the tests complete:

  iojs 2556558       1 120 15:37:44  pts/0 35:12 /home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/out/Release/node /home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-vm-sigint-existing-handler.js child

Not sure if this is AIX specific or not as I've only see it on AIX at this point.
@mhdawson
Copy link
Member Author

mhdawson commented Aug 4, 2016

Now see that this test is failing in the runs:

not ok 1074 parallel/test-vm-sigint-existing-handler
# CRASHED (Signal: 31)

which is most likely the cause of the stray process

@mhdawson mhdawson changed the title AIX: /test-vm-sigint-existing-handler.js AIX: test-vm-sigint-existing-handler failing Aug 4, 2016
@mhdawson mhdawson added the test Issues and PRs related to the tests. label Aug 4, 2016
@addaleax addaleax self-assigned this Aug 4, 2016
@addaleax
Copy link
Member

addaleax commented Aug 4, 2016

I think this just requires the same kind of change that #7854 made, will have a PR up in a minute

@mhdawson
Copy link
Member Author

mhdawson commented Aug 4, 2016

@addaleax thanks.

addaleax added a commit to addaleax/node that referenced this issue Aug 4, 2016
@addaleax
test: fix flaky test-vm-sigint-existing-handler
f0bf2c2 
Set the `SIGUSR2` handler before spawning the child process to make sure
the signal is always handled.

Ref: nodejs#7854
Fixes: nodejs#7981
@addaleax addaleax mentioned this issue Aug 4, 2016
Closed
3 tasks
@mscdex mscdex added the vm Issues and PRs related to the vm subsystem. label Aug 4, 2016
cjihrig pushed a commit that referenced this issue Aug 10, 2016
@addaleax @cjihrig
test: fix flaky test-vm-sigint-existing-handler
a385277 
Set the `SIGUSR2` handler before spawning the child process to make sure
the signal is always handled.

Ref: #7854
Fixes: #7981
PR-URL: #7982
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@addaleax addaleax

Labels
test Issues and PRs related to the tests. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mscdex @addaleax @mhdawson