Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: assert.strictEqual and linting #10036

Closed
wants to merge 2 commits into from
Closed

test: assert.strictEqual and linting #10036

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acdce8b
test: assert.strictEqual and linting
furnox Dec 1, 2016
3eeb2bb
test: use string interpolation and assert.ifError
Dec 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions test/parallel/test-pipe-head.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
'use strict';
var common = require('../common');
var assert = require('assert');
const common = require('../common');
const assert = require('assert');

var exec = require('child_process').exec;
var join = require('path').join;
const exec = require('child_process').exec;
const join = require('path').join;

var nodePath = process.argv[0];
var script = join(common.fixturesDir, 'print-10-lines.js');
const nodePath = process.argv[0];
const script = join(common.fixturesDir, 'print-10-lines.js');

var cmd = '"' + nodePath + '" "' + script + '" | head -2';
const cmd = '"' + nodePath + '" "' + script + '" | head -2';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good candidate for a template string.


exec(cmd, common.mustCall(function(err, stdout, stderr) {
if (err) throw err;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be assert.ifError(err);

var lines = stdout.split('\n');
assert.equal(3, lines.length);
const lines = stdout.split('\n');
assert.strictEqual(3, lines.length);
}));