Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7.3.0 proposal #10277

Merged
merged 129 commits into from
Dec 20, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
129 commits
Select commit Hold shift + click to select a range
9d04152
build: Don't regenerate node symlink
Nov 28, 2016
e61331e
build: fix node_g target
danbev Dec 6, 2016
1864222
doc: var => const/let in the buffer.md
vsemozhetbyt Nov 25, 2016
9e47b94
doc: fix a syntax error in the buffer.md
vsemozhetbyt Nov 26, 2016
3b848a2
doc: fix wrong function arguments in the buffer.md
vsemozhetbyt Nov 26, 2016
622690f
doc: fix copy-paste artifacts in the buffer.md
vsemozhetbyt Nov 26, 2016
39b083e
doc: repeat a remark as needed in the buffer.md
vsemozhetbyt Nov 26, 2016
7a39a44
doc: remove a wrong remark in the buffer.md
vsemozhetbyt Nov 26, 2016
d373b2f
doc: fix examples in buffer.md to avoid confusion
vsemozhetbyt Nov 26, 2016
d4c73d4
doc: remove an extraneous word in the buffer.md
vsemozhetbyt Nov 27, 2016
bc64a63
doc: fix a wrong note in the buffer.md
vsemozhetbyt Dec 4, 2016
bb91747
test: fix test for buffer regression #649
joyeecheung Dec 1, 2016
4d66578
test: use ES6 to update let & const
GreenPioneer Dec 1, 2016
5ca9077
test: refactor test-stdin-from-file.js
Dec 1, 2016
de99726
test: refactor test-domain-exit-dispose
Dec 1, 2016
c66cf2c
test: refactor tls-ticket-cluster
shri3k Dec 1, 2016
eb1664b
test: refactor test-event-emitter-method-names
Dec 1, 2016
6489a91
test: refactor test-listen-fd-ebadf
Dec 1, 2016
6f2f02d
test: invalid package.json causes error when require()ing in directory
Dec 1, 2016
d8dc890
test: assert.throws() should include a RegExp
cByst Dec 1, 2016
01509bc
test: move long-running test to sequential
Trott Dec 7, 2016
19432f0
test: refactor test-dgram-bind-default-address
mbchoa Dec 1, 2016
62f5a0b
test: check result of uv_loop_init and uv_write
bnoordhuis Dec 5, 2016
6d4f270
test: use const and strictEqual in test-os-homedir-no-envvar
codeVana Dec 1, 2016
2c5d562
test: refactor test-domain-exit-dispose-again
Ethan-Arrowood Dec 1, 2016
be90638
test: refactor test-domain-from-timer
Dec 1, 2016
39bf5bf
doc: removing extra space in README
italoacasas Dec 7, 2016
e695862
test: improve test-fs-read-stream.js
jennabelle Nov 16, 2016
d64e52c
doc: adding missing - in README
italoacasas Dec 7, 2016
1114080
test: refactor test-beforeexit-event
radelmann Dec 4, 2016
2565e48
test: refactor test-https-agent-session-reuse
dpaez Dec 3, 2016
9d037cf
test: improves test-tls-client-verify
Dec 1, 2016
d7988e0
test: renamed assert.Equal to assert.strictEqual
triscuitoraus Dec 1, 2016
dac757e
test: changed assert.equal to assert.strictEqual
zina-olson Dec 1, 2016
72fb05d
test: change assert.equal to assert.strictEqual
Dec 1, 2016
b67cad1
test: use `assert.strictEqual`
anoff Dec 1, 2016
778e5f7
test: fix error in test-cluster-worker-death.js
Dec 1, 2016
3034038
doc: add a variable declaration in the buffer.md
vsemozhetbyt Nov 26, 2016
19d7197
url: add a got host pattern in url.js
AxelMonroyX Dec 6, 2016
b41db33
inspector: check if connected before waiting
Dec 2, 2016
f08d8a6
url: improve URLSearchParams spec compliance
TimothyGu Nov 6, 2016
a9d4bd7
test: refactor test-crypto-hmac
eudaimos Dec 1, 2016
ae53a6e
doc: update `path.format` description and examples
anoff Dec 1, 2016
ca38f70
test: refactor test-net-keepalive.js
kmccmk9 Dec 1, 2016
20fdf3a
doc: add some info on `tty#setRawMode()`
Fishrock123 Dec 6, 2016
53e8e96
test: fix flaky test-net-socket-timeout
Trott Dec 7, 2016
dded482
http: remove stale timeout listeners
Nov 1, 2016
8b7c97b
test: increase test coverage of BufferList
joyeecheung Dec 1, 2016
1ebb5b9
test: refactor test-http-unix-socket
Dec 1, 2016
3a460d5
test: check for error on invalid signal
mattcphillips Dec 1, 2016
cc5bd9a
tools: add macosx-firwall script to avoid popups
danbev Dec 3, 2016
f5347ab
test: set stdin too for pseudo-tty tests
addaleax Dec 6, 2016
28c6df2
test: add stdin-setrawmode.out file
Dec 6, 2016
5a64187
doc: buffer allocation throws for negative size
joyeecheung Dec 6, 2016
ff8fdb1
doc: add note to parallelize make
Dec 1, 2016
b44e789
doc: standardizing on make -j4
Dec 6, 2016
b6a8bc6
lib,test: use consistent operator linebreak style
targos Dec 8, 2016
a92f2ad
tools: enforce consistent operator linebreak style
targos Dec 8, 2016
c792e2a
test: stream readableListening internal state
italoacasas Dec 1, 2016
6780c0e
test: stream readableState readingMore state
chmln Dec 1, 2016
3e8df73
test: improving crypto fips
Dec 1, 2016
1f11deb
test: improve buffer transcode
Dec 1, 2016
80cccce
url, test: including base argument in originFor
joyeecheung Dec 1, 2016
3f269cc
test: use ES6 in test-debugger-client.js
edsadr Dec 8, 2016
40b0ca1
doc: fix typo in code example of 'path' module
pallxk Dec 6, 2016
09ec5db
test: fail for missing output files
addaleax Dec 6, 2016
d8b6723
buffer: handle UCS2 `.fill()` properly on BE
addaleax Dec 6, 2016
b99a372
buffer: fix single-character string filling
addaleax Nov 29, 2016
88839cf
test: replace var with const in test-require-dot
amarzavery Dec 1, 2016
7f01484
test: add ES6 and strictEqual to test-fs-truncate
edsadr Dec 7, 2016
e1d813f
test: refactor test-handle-wrap-close-abort
Trott Dec 9, 2016
3749dc6
test: refactor http pipelined socket test
Trott Dec 9, 2016
8b698d8
test: refactor assert.equal, update syntax to ES6
Dec 1, 2016
2b78212
test: use strictEqual in test-debug-break
edsadr Dec 8, 2016
ec2f13f
src: don't overwrite non-writable vm globals
bnoordhuis Dec 11, 2016
be87441
test: refactor test-http-after-connect.js
larissayvette Dec 11, 2016
d5e30a6
test: refactor test-fs-fsync
radelmann Dec 7, 2016
a4f3080
test: improvements in test fixtures symlinked
edsadr Dec 12, 2016
90659bc
test: fix flaky test-dgram-exclusive-implicit-bind
Trott Dec 10, 2016
2f9c8d9
test: refactor test-http-pause-resume-one-end
Trott Dec 10, 2016
a97f264
test: refactor test-crypto-random
Trott Dec 12, 2016
2da71f2
url, test: fix typo in inspect output, add test
Dec 12, 2016
2673be6
fs: remove unused argument from copyObject()
Ethan-Arrowood Dec 1, 2016
b9361ca
test: refactor test-http-dns-fail
edsadr Dec 12, 2016
f664613
timers: fix handling of cleared immediates
hassy Nov 23, 2016
c0800d9
test: refactor test-stream-big-push
Trott Dec 11, 2016
60542cb
test: refactor test-domain.js
sidthekidder Dec 9, 2016
308cead
test: update test-domain-uncaught-exception.js
amazingandyyy Dec 9, 2016
553a326
test: fix http-client-timeout-option-listeners
Trott Dec 11, 2016
d4e160c
src: add wrapper for process.emitWarning()
sam-github Nov 7, 2016
6963e8a
crypto: allow adding extra certs to well-known CAs
sam-github Oct 17, 2016
24482d0
url: add inspect function to TupleOrigin
captainsafia Dec 1, 2016
d9cfd54
test: clean up domain-no-error-handler test
weyj4 Dec 15, 2016
74563f0
test: refactor domain test
junior Dec 1, 2016
8c8b123
test: use const/let and common.mustCall
outsideris Dec 1, 2016
46c55a6
test: cleanup test-stdout-close-catch.js
furnox Dec 1, 2016
ee736b2
doc: fix broken link in COLLABORATOR_GUIDE.md
mhdawson Dec 14, 2016
ef2fa56
src: fix string format mistake for 32 bit node
posix4e Dec 1, 2016
16fbd4f
test: refactor test-tls-ecdh-disable
Dec 1, 2016
fb297cb
test: refactor test-dgram-send-callback-multi-buffer
mfhan Dec 1, 2016
28ffd59
stream, test: test _readableState.emittedReadable
joyeecheung Dec 13, 2016
7e8c5e3
doc: expand common module material in test guide
Trott Dec 13, 2016
e4b29a5
test: refactor test-fs-read-stream-inherit
Trott Dec 13, 2016
ea16a2a
test: stream readable needReadable state
joyeecheung Dec 12, 2016
6b98906
doc: document R CRAN mirror process
lholmquist Dec 10, 2016
7c3d280
doc: rework tls for accuracy and clarity
sam-github Nov 23, 2016
41e1e6e
tls: do not refer to secureOptions as flags
sam-github Nov 22, 2016
980acb4
tls: document and test option-less createServer
sam-github Nov 21, 2016
8e4b9fa
tls: fix/annotate connect arg comments
sam-github Nov 18, 2016
8a34e60
test: var to const in tls-no-cert-required
sam-github Dec 9, 2016
8b9131c
test: tls key/cert ordering not necessary
sam-github Nov 22, 2016
ce1968c
test: improve test-child-process-exec-buffer
edsadr Dec 17, 2016
a20480c
test: add known_issues test for #6287
AnnaMag Dec 14, 2016
67c2930
test: fix flaky test-http-client-timeout-event
Trott Dec 15, 2016
be6d362
tools: forbid template literals in assert.throws
targos Dec 16, 2016
7689602
test: improve test-child-process-fork-and-spawn
edsadr Dec 17, 2016
ace5cad
test: refactor the code in test-dns-ipv6
edsadr Dec 16, 2016
663c44e
cluster: return worker reference from disconnect()
stv8 Dec 1, 2016
88086ce
test: fix flaky test-debug-port
santigimeno Dec 17, 2016
2096638
tls: allow obvious key/passphrase combinations
sam-github Dec 15, 2016
5bc0ae8
stream_base: homogenize req_wrap_obj use
indutny Dec 8, 2016
d685c99
deps: cherry-pick 081fce3 from V8 upstream
Dec 19, 2016
0075836
test: improve code in test-fs-open.js
edsadr Dec 17, 2016
2e0386c
fs: remove needless assignment of null
reconbot Dec 13, 2016
02dc680
doc: fix typo in ecdhCurve, a tls property name
sam-github Dec 19, 2016
fc40ae3
win,msi: add required UIRef for localized strings
billti Oct 1, 2016
cc9b4b7
test: stream readable resumeScheduled state
italoacasas Dec 16, 2016
24a3d0e
2016-12-20, Version 7.3.0 (Current)
cjihrig Dec 20, 2016
586967a
Working on v7.3.1
cjihrig Dec 20, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ rules:
no-multiple-empty-lines: [2, {max: 2, maxEOF: 0, maxBOF: 0}]
no-tabs: 2
no-trailing-spaces: 2
operator-linebreak: [2, after, {overrides: {'?': ignore, ':': ignore}}]
quotes: [2, single, avoid-escape]
semi: 2
semi-spacing: 2
Expand Down
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
##### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [ ] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes
- [ ] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes
- [ ] tests and/or benchmarks are included
- [ ] documentation is changed or added
- [ ] commit message follows commit guidelines
Expand Down
19 changes: 18 additions & 1 deletion BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,33 @@ On OS X, you will also need:
this under the menu `Xcode -> Preferences -> Downloads`
* This step will install `gcc` and the related toolchain containing `make`

* You may want to setup [firewall rules](tools/macosx-firewall.sh) to avoid
popups asking to accept incoming network connections when running tests:

```console
$ sudo ./tools/macosx-firewall.sh
```
Running this script will add rules for the executable `node` in the out
directory and the symbolic `node` link in the projects root directory.

On FreeBSD and OpenBSD, you may also need:
* libexecinfo

To build Node.js:

```console
$ ./configure
$ make
$ make -j4
```

Running `make` with the `-j4` flag will cause it to run 4 compilation jobs
concurrently which may significantly reduce build time. The number after `-j`
can be changed to best suit the number of processor cores on your machine. If
you run into problems running `make` with concurrency, try running it without
the `-j4` flag. See the
[GNU Make Documentation](https://www.gnu.org/software/make/manual/html_node/Parallel.html)
for more information.

Note that the above requires that `python` resolve to Python 2.6 or 2.7 and not a newer version.

To run the tests:
Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ release.
</tr>
<tr>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V7.md#7.2.1">7.2.1</a></b><br/>
<b><a href="doc/changelogs/CHANGELOG_V7.md#7.3.0">7.3.0</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V7.md#7.2.1">7.2.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V7.md#7.2.0">7.2.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V7.md#7.1.0">7.1.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V7.md#7.0.0">7.0.0</a><br/>
Expand Down
5 changes: 3 additions & 2 deletions COLLABORATOR_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ information regarding the change process:
- Protects against the assumption that GitHub will be around forever.

Review the commit message to ensure that it adheres to the guidelines
outlined in the [contributing](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit) guide.
outlined in the [contributing](./CONTRIBUTING.md#step-3-commit) guide.

See the commit log for examples such as
[this one](https://github.com/nodejs/node/commit/b636ba8186) if unsure
Expand Down Expand Up @@ -237,7 +237,8 @@ Save the file and close the editor. You'll be asked to enter a new
commit message for that commit. This is a good moment to fix incorrect
commit logs, ensure that they are properly formatted, and add
`Reviewed-By` lines.
* The commit message text must conform to the [commit message guidelines](../CONTRIBUTING.md#step-3-commit).
* The commit message text must conform to the
[commit message guidelines](./CONTRIBUTING.md#step-3-commit).

Time to push it:

Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ to see how they should be structured can also help.
To run the tests on Unix / OS X:

```text
$ ./configure && make -j8 test
$ ./configure && make -j4 test
```

Windows:
Expand Down Expand Up @@ -189,7 +189,7 @@ You can run tests directly with node:
$ ./node ./test/parallel/test-stream2-transform.js
```

Remember to recompile with `make -j8` in between test runs if you change
Remember to recompile with `make -j4` in between test runs if you change
core modules.

### Step 6: Push
Expand Down
9 changes: 7 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,18 @@ endif
# to check for changes.
.PHONY: $(NODE_EXE) $(NODE_G_EXE)

# The -r/-L check stops it recreating the link if it is already in place,
# otherwise $(NODE_EXE) being a .PHONY target means it is always re-run.
# Without the check there is a race condition between the link being deleted
# and recreated which can break the addons build when running test-ci
# See comments on the build-addons target for some more info
$(NODE_EXE): config.gypi out/Makefile
$(MAKE) -C out BUILDTYPE=Release V=$(V)
ln -fs out/Release/$(NODE_EXE) $@
if [ ! -r $@ -o ! -L $@ ]; then ln -fs out/Release/$(NODE_EXE) $@; fi

$(NODE_G_EXE): config.gypi out/Makefile
$(MAKE) -C out BUILDTYPE=Debug V=$(V)
ln -fs out/Debug/$(NODE_EXE) $@
if [ ! -r $@ -o ! -L $@ ]; then ln -fs out/Debug/$(NODE_EXE) $@; fi

out/Makefile: common.gypi deps/uv/uv.gyp deps/http_parser/http_parser.gyp \
deps/zlib/zlib.gyp deps/v8/gypfiles/toolchain.gypi \
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,8 @@ more information about the governance of the Node.js project, see
**Ilkka Myller** &lt;[email protected]&gt;
* [isaacs](https://github.com/isaacs) -
**Isaac Z. Schlueter** &lt;[email protected]&gt;
* [italoacasas](https://github.com/italoacasas)
**Italo A. Casas** &lt;[email protected]&gt;
* [italoacasas](https://github.com/italoacasas) -
**Italo A. Casas** &lt;[email protected]&gt;
* [iWuzHere](https://github.com/iWuzHere) -
**Imran Iqbal** &lt;[email protected]&gt;
* [JacksonTian](https://github.com/JacksonTian) -
Expand Down
15 changes: 15 additions & 0 deletions benchmark/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,21 @@ install.packages("ggplot2")
install.packages("plyr")
```

### CRAN Mirror Issues
In the event you get a message that you need to select a CRAN mirror first.

You can specify a mirror by adding in the repo parameter.

If we used the "http://cran.us.r-project.org" mirror, it could look somehting like
this:

```R
install.packages("ggplot2", repo="http://cran.us.r-project.org")
```

Of course, use the mirror that suits your location.
A list of mirrors is [located here](https://cran.r-project.org/mirrors.html).

## Running benchmarks

### Running individual benchmarks
Expand Down
2 changes: 1 addition & 1 deletion deps/v8/include/v8-version.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#define V8_MAJOR_VERSION 5
#define V8_MINOR_VERSION 4
#define V8_BUILD_NUMBER 500
#define V8_PATCH_LEVEL 44
#define V8_PATCH_LEVEL 45

// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
Expand Down
4 changes: 3 additions & 1 deletion deps/v8/src/base/platform/time.cc
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@ bool TimeTicks::IsHighResolutionClockWorking() {

bool ThreadTicks::IsSupported() {
#if (defined(_POSIX_THREAD_CPUTIME) && (_POSIX_THREAD_CPUTIME >= 0)) || \
defined(V8_OS_MACOSX) || defined(V8_OS_ANDROID)
defined(V8_OS_MACOSX) || defined(V8_OS_ANDROID) || defined(V8_OS_SOLARIS)
return true;
#elif defined(V8_OS_WIN)
return IsSupportedWin();
Expand All @@ -655,6 +655,8 @@ ThreadTicks ThreadTicks::Now() {
#elif(defined(_POSIX_THREAD_CPUTIME) && (_POSIX_THREAD_CPUTIME >= 0)) || \
defined(V8_OS_ANDROID)
return ThreadTicks(ClockNow(CLOCK_THREAD_CPUTIME_ID));
#elif V8_OS_SOLARIS
return ThreadTicks(gethrvtime() / Time::kNanosecondsPerMicrosecond);
#elif V8_OS_WIN
return ThreadTicks::GetForThread(::GetCurrentThread());
#else
Expand Down
Loading