Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: consistent 'Returns:' part two #10391

Closed
wants to merge 1 commit into from
Closed

doc: consistent 'Returns:' part two #10391

wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Follow up from 8eb19c4. Lower case return was not updated

Ref: #9554

@MylesBorins
doc: consistent 'Returns:' part two
e10e6e3 
Follow up from 8eb19c4. Lower case `return` was not updated

Ref: nodejs#9554
@MylesBorins MylesBorins added the doc Issues and PRs related to the documentations. label Dec 21, 2016
Fishrock123
Fishrock123 approved these changes Dec 21, 2016
View reviewed changes
Copy link
Contributor

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, can we codify this somewhere?

@MylesBorins
Copy link
Contributor Author

We have a markdown linter don't we? I can dig in to see if we can add a rule

@Trott
Copy link
Member

Trott commented Dec 21, 2016

FWIW, the minimal doc for common in the test directory README does not conform to this. Perhaps fixing that is a good first contribution issue.

@MylesBorins
Copy link
Contributor Author

landed in 0bdd39f

MylesBorins added a commit that referenced this pull request Dec 23, 2016
@MylesBorins
doc: consistent 'Returns:' part two
0bdd39f 
Follow up from 8eb19c4. Lower case `return` was not updated

PR-URL: #10391
Ref: #9554
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Julian Duque <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@evanlucas evanlucas mentioned this pull request Jan 3, 2017
Merged
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
@MylesBorins @evanlucas
doc: consistent 'Returns:' part two
ec6bddf 
Follow up from 8eb19c4. Lower case `return` was not updated

PR-URL: #10391
Ref: #9554
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Julian Duque <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
@MylesBorins @evanlucas
doc: consistent 'Returns:' part two
4365bb4 
Follow up from 8eb19c4. Lower case `return` was not updated

PR-URL: #10391
Ref: #9554
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Julian Duque <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins added a commit that referenced this pull request Jan 23, 2017
@MylesBorins
doc: consistent 'Returns:' part two
d8fe84e 
Follow up from 8eb19c4. Lower case `return` was not updated

PR-URL: #10391
Ref: #9554
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Julian Duque <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins added a commit that referenced this pull request Jan 23, 2017
@MylesBorins
doc: consistent 'Returns:' part two
6993d1c 
Follow up from 8eb19c4. Lower case `return` was not updated

PR-URL: #10391
Ref: #9554
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Julian Duque <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins added a commit that referenced this pull request Jan 24, 2017
@MylesBorins
doc: consistent 'Returns:' part two
eef36e9 
Follow up from 8eb19c4. Lower case `return` was not updated

PR-URL: #10391
Ref: #9554
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Julian Duque <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins added a commit that referenced this pull request Jan 24, 2017
@MylesBorins
doc: consistent 'Returns:' part two
9f1b188 
Follow up from 8eb19c4. Lower case `return` was not updated

PR-URL: #10391
Ref: #9554
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Julian Duque <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Jan 24, 2017
Merged
Merged
MylesBorins added a commit that referenced this pull request Jan 31, 2017
@MylesBorins
doc: consistent 'Returns:' part two
59aa4e9 
Follow up from 8eb19c4. Lower case `return` was not updated

PR-URL: #10391
Ref: #9554
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Julian Duque <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins added a commit that referenced this pull request Feb 1, 2017
@MylesBorins
doc: consistent 'Returns:' part two
dda777b 
Follow up from 8eb19c4. Lower case `return` was not updated

PR-URL: #10391
Ref: #9554
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Julian Duque <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins deleted the doc-returns-two branch November 14, 2017 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@jasnell jasnell jasnell approved these changes

@julianduque julianduque julianduque approved these changes

@addaleax addaleax addaleax approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@MylesBorins @Trott @silverwind @jasnell @julianduque @addaleax @Fishrock123 @lpinca @cjihrig