v4.8.1 proposal #11760
Merged
v4.8.1 proposal #11760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original commit message: [debug] load correct stack slot for frame details. [email protected] BUG=v8:5071 Review URL: https://codereview.chromium.org/2045863002 . Cr-Commit-Position: refs/heads/master@{#36769} PR-URL: #10873 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Reviewed-By: jasnell - James M Snell <[email protected]> Reviewed-By: ofrobots - Ali Ijaz Sheikh <[email protected]>
An application using node built as a shared library may legitimately implement its own signal handling routines. Current behaviour is to squash all signal handlers on node startup. This change will stop that behaviour when node is built as a shared library. PR-URL: #10539 Fixes: #10520 Refs: #615 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
SecureContext::AddRootCerts only parses the root certificates once and keeps the result in root_cert_store, a global X509_STORE. This change addresses the following issues: 1. SecureContext::AddCACert would add certificates to whatever X509_STORE was being used, even if that happened to be root_cert_store. Thus adding a CA certificate to a SecureContext would also cause it to be included in unrelated SecureContexts. 2. AddCRL would crash if neither AddRootCerts nor AddCACert had been called first. 3. Calling AddCACert without calling AddRootCerts first, and with an input that didn't contain any certificates, would leak an X509_STORE. 4. AddCRL would add the CRL to whatever X509_STORE was being used. Thus, like AddCACert, unrelated SecureContext objects could be affected. The following, non-obvious behaviour remains: calling AddRootCerts doesn't /add/ them, rather it sets the CA certs to be the root set and overrides any previous CA certificates. Points 1–3 are probably unimportant because the SecureContext is typically configured by `createSecureContext` in `lib/_tls_common.js`. This function either calls AddCACert or AddRootCerts and only calls AddCRL after setting up CA certificates. Point four could still apply in the unlikely case that someone configures a CRL without explicitly configuring the CAs. PR-URL: #9409 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
Fix leaking the BIO in the error path. Introduced in commit 34febfb ("crypto: fix handling of root_cert_store"). PR-URL: #9604 Refs: #9409 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
This makes sure that we dump a backtrace and use raise(SIGABRT) on Windows. PR-URL: #9613 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Use of abort() was added in 34febfb, and changed to ABORT() in 21826ef, but conditional+ABORT() is better expressesed using a CHECK_xxx() macro. See: #9409 (comment) PR-URL: #10413 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
This test is newly added to v4.x stream and is consistently failing. We have a couple of issues with pseudo-tty tests in AIX, and while the investigation is going on, need to skip this test to make CI green. PR-URL: #11602 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Unsanitized paths containing line feed characters can be used for header injection and request splitting so reject them with an exception. There seems to be no reasonable use case for allowing control characters (characters <= 31) while there are several scenarios where they can be used to exploit software bugs so reject control characters altogether. PR-URL: #8923 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: not-an-aardvark <[email protected]>
PR-URL: #9649 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
The node -> out/*/node symlink is getting recreated in parallel with other targets in the makefile which require it (e.g. test-ci) and this seems to be causing a race condition which is showing up on AIX Fixes: #9825 PR-URL: #9827 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-by: Michael Dawson <[email protected]>
Currently when running make node_g the following error is displayed: if [ ! -r node -o ! -L ]; then ln -fs out/Debug/node node_g; fi /bin/sh: line 0: [: argument expected It looks like there was a typo for the NODE_EXE where node became lowercase instead of uppercase. Ref: #9827 PR-URL: #10153 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
Provide details for fields of rinfo object of UDP message event. PR-URL: #10050 Reviewed-By: James M Snell <[email protected]>
The COLLABORATOR_GUIDE was still listing v0.10 and v0.12 as LTS when they are EOL now. PR-URL: #10720 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]>
git apply does not preserve the original commit message. These updated instructions offer a simpler flow for backporting. PR-URL: #10665 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michal Zasso <[email protected]>
The guide for writing tests is missing information on how tests are named. This adds that information. There is also some copy-editing done on the first paragraph of the guide. PR-URL: #10584 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
PR-URL: #10616 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Prince John Wesley <[email protected]>
Add links to the engine classes for the zlib single-call convenience methods. PR-URL: #10829 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
This commit clarifies variables in the Filesystem docs. Prior, the documentation for fs.write() had an ambiguous remark on the parameters of offset and length. Therefore, this commit makes explicit that the length parameter in fs.write() is used to denote the number of bytes, which is a clearer reference for its usage. PR-URL: #9792 Ref: #7868 Reviewed-By: Sam Roberts <[email protected]>
PR-URL: #10883 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #10954 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Changed authors listing from `Noah Rose` to `Noah Rose Ledesma`. PR-URL: #10945 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
* use common.mustCall() where appropriate * Buffer.allocUnsafe() -> Buffer.alloc() * do crypto check before loading any additional modules * specify 1ms duration for `setTimeout()` PR-URL: #10225 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
We were transporting the heap statistics as uint32 values to JS land but those wrap around for values > 4 GB. Use 64 bits floats instead, those should last us a while. Fixes: #10185 PR-URL: #10186 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
new year new alias PR-URL: #10586 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Remove the numbers from the comments to make it clear that assert does not follow the [CJS spec](http://wiki.commonjs.org/wiki/Unit_Testing/1.0). Additionally, clean up the existing comments for consistent formatting/language and ease of reading. PR-URL: #10579 Fixes: #9063 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #10446 Reviewed-By: James M Snell <[email protected]>
Fixes: nodejs/CTC#41 PR-URL: #10604 Fixes: https://github.com/nodejs/CTC#41 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Michal Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
* Change === to == in one place * Add explanation about another non-strict if-statement PR-URL: #11513 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Add documentation for http clientRequest.aborted. PR-URL: #11544 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Communicate about leaked globals via `AssertionError` rather than `console.log()`. PR-URL: #11547 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Because any call to util.inspect() with an object results in inspectPromise() being called, Debug was being initialized even when it's not needed. Instead, the initialization is placed after the isPromise check. PR-URL: #8452 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
nodejs-github-bot
added
build
This commit adds a guard against an out of bounds access of arguments, and replaces another use of arguments with a named function parameter. Refs: #10323
MylesBorins
force-pushed
the
v4.8.1-proposal
branch
from
8af0946 to
9d6a625
Compare
`request.abort()` did not destroy the socket if it was called before a socket was assigned to the request and the request did not use an `Agent` or a Unix Domain Socket was used. Fixes: #10812 PR-URL: #10818 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
MylesBorins
force-pushed
the
v4.8.1-proposal
branch
from
9d6a625 to
9b66466
Compare
|
Left it too long, one more run: ci: https://ci.nodejs.org/job/node-test-pull-request/6949/ edit: CI is good! edit 2: Three failures to look into for CITGM ubuntu 1404 ember-cli /cc @stefanpenner it looks like the failing test was a timeout... but the error messages in the output are concerning ubuntu 1604 readable-stream Looks like the tmpdir /cc @mcollina osx ws this is really weird, will attempt to reproduce locally |
|
Notable changes seems significantly smaller here. ### Notable Changes
* **buffer**: The performance of `.toJSON()` is now up to 2859% faster on average. (Brian White) [#10895](https://github.com/nodejs/node/pull/10895)
* **IPC**: Batched writes have been enabled for process IPC on platforms that support Unix Domain Sockets. (Alexey Orlenko) [#10677](https://github.com/nodejs/node/pull/10677)
- Performance gains may be up to 40% for some workloads.
* **http**:
- Control characters are now always rejected when using `http.request()`. (Ben Noordhuis) [#8923](https://github.com/nodejs/node/pull/8923)
* **node**: Heap statistics now support values larger than 4GB. (Ben Noordhuis) [#10186](https://github.com/nodejs/node/pull/10186) |
MylesBorins
force-pushed
the
v4.8.1-proposal
branch
from
9b66466 to
92093b0
Compare
Notable Changes:
* buffer:
- The performance of `.toJSON()` is now up to 2859% faster on average
(Brian White) #10895
* IPC:
- Batched writes have been enabled for process IPC on platforms that
support Unix Domain Sockets. (Alexey Orlenko)
#10677
- Performance gains may be up to 40% for some workloads.
* http:
- Control characters are now always rejected when using
`http.request()`. (Ben Noordhuis)
#8923
* node:
- Heap statistics now support values larger than 4GB. (Ben Noordhuis)
#10186
MylesBorins
force-pushed
the
v4.8.1-proposal
branch
from
92093b0 to
9551665
Compare
MylesBorins
added a commit
that referenced
this pull request
Mar 21, 2017
Notable Changes:
* buffer:
- The performance of `.toJSON()` is now up to 2859% faster on average
(Brian White) #10895
* IPC:
- Batched writes have been enabled for process IPC on platforms that
support Unix Domain Sockets. (Alexey Orlenko)
#10677
- Performance gains may be up to 40% for some workloads.
* http:
- Control characters are now always rejected when using
`http.request()`. (Ben Noordhuis)
#8923
* node:
- Heap statistics now support values larger than 4GB. (Ben Noordhuis)
#10186
PR-URL: #11760
|
It's not an issue, but for posterity the head commit on v4.x (89a83a5) says cc/ @BethGriggs (who noticed) |
This is the issue: https://github.com/nodejs/build/blob/master/setup/ubuntu16.04/resources/jenkins.service.j2#L17 but it is not present in the others: https://github.com/nodejs/build/blob/master/setup/fedora22/resources/jenkins.service. |
|
good eye. I've gone ahead and force pushed to fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2017-03-21, Version 4.8.1 'Argon' (LTS), @MylesBorins
This LTS release comes with 147 commits. This includes 55 which are test related,
41 which are doc related, 11 which are build / tool related,
and 1 commits which are updates to dependencies.
Notable Changes
Coming Soon
Commits
77f23ec5af] - assert: unlock the assert API (Rich Trott) #11304090037a41a] - assert: remove unneeded condition (Rich Trott) #1131475af859af7] - assert: apply minor refactoring (Rich Trott) #11511994f562858] - assert: update comments (Kai Cataldo) #1057914e57c1102] - benchmark: add more thorough timers benchmarks (Jeremiah Senkpiel) #10925850f85d96e] - benchmark: add benchmark for object properties (Michaël Zasso) #10949626875f2e4] - benchmark: don't lint autogenerated modules (Brian White) #107569da6ebd73f] - benchmark: add dgram bind(+/- params) benchmark (Vse Mozhet Byt) #11313a597c11ba4] - benchmark: improve readability of net benchmarks (Brian White) #1044622c25dee92] - buffer: improve toJSON() performance (Brian White) #10895af3c21197d] - build: move source files from headers section (Daniel Bevenius) #108504bb61553f0] - build: disable C4267 conversion compiler warning (Ben Noordhuis) #112056a45ac0ea9] - build: fix newlines in addon build output (Brian White) #11466bfc553d55d] - build: fail on CI if leftover processes (Rich Trott) #11269094bfe66aa] - build: fix node_g target (Daniel Bevenius) #1015387db4f7225] - build: Don't regenerate node symlink (sxa555) #9827e0dc0ceb37] - build: don't squash signal handlers with --shared (Stewart X Addison) #105394676eec382] - child_process: remove empty if condition (cjihrig) #114272b867d2ae5] - child_process: refactor internal/child_process.js (Arseniy Maximov) #11366c9a92ff494] - crypto: return the retval of HMAC_Update (Travis Meisenheimer) #108919c53e402d7] - crypto: freelist_max_len is gone in OpenSSL 1.1.0 (Adam Langley) #10859c6f6b029a1] - crypto: add cert check issued by StartCom/WoSign (Shigeki Ohtsu) #9469c56719f47a] - crypto: Remove expired certs from CNNIC whitelist (Shigeki Ohtsu) #9469b48f6ffc63] - crypto: use CHECK_NE instead of ABORT or abort (Sam Roberts) #1041335a660ee70] - crypto: fix handling of root_cert_store. (Adam Langley) #94093516f35b77] - deps: backport 7c3748a from upstream V8 (Cristian Cavalli) #10873f9e121ead8] - dgram: fix possibly deoptimizing use of arguments (Vse Mozhet Byt)fc2bb2c8ef] - doc: remove Chris Dickinson from active releasers (Ben Noordhuis) #11011725a89606b] - doc: remove duplicate properties bullet in readme (Javis Sullivan) #10741db03294c41] - doc: fix typo in http.md (Peter Mescalchin) #1097515188900b8] - doc: add who to CC list for dgram (cjihrig) #11035a0742902bd] - doc: correct and complete dgram's Socket.bind docs (Alex Jordan) #11025f464dd837f] - doc: edit CONTRIBUTING.md for clarity (Rich Trott) #1104507dfed8f45] - doc: fix confusing example in dns.md (Vse Mozhet Byt) #11022d55d760086] - doc: add personal pronouns option (Rich Trott) #11089b86843a463] - doc: clarify msg when doc/api/cli.md not updated (Stewart X Addison) #10872c2d70908e6] - doc: edit stability text for clarity and style (Rich Trott) #11112115448ec94] - doc: remove assertions about assert (Rich Trott) #11113e90317d739] - doc: fix "initial delay" link in http.md (Timo Tijhof) #11108788d736ab6] - doc: typographical fixes in COLLABORATOR_GUIDE.md (Anna Henningsen) #111632016aa4e07] - doc: add not-an-aardvark as ESLint contact (Rich Trott) #111692b6ee39264] - doc: improve testing guide (Joyee Cheung) #11150aae768c599] - doc: remove extraneous paragraph from assert doc (Rich Trott) #11174ca4b2f6154] - doc: fix typo in dgram doc (Rich Trott) #11186bb1e97c31a] - doc: add and fix System Error properties (Daiki Arai) #10986e1e02efac5] - doc: clarify the behavior of Buffer.byteLength (Nikolai Vavilov) #1123830d9202f54] - doc: improve consistency in documentation titles (Vse Mozhet Byt) #1123010afa8befc] - doc: drop "and io.js" from release section (Ben Noordhuis) #110546f1db35e27] - doc: update email and add personal pronoun (JungMinu) #1131861ac3346ba] - doc: update code examples in domain.md (Vse Mozhet Byt) #111100c9ea4fe8b] - doc: dns examples implied string args were arrays (Sam Roberts) #11350485ec6c180] - doc: change STYLE-GUIDE to STYLE_GUIDE (Dean Coakley) #1146041bf266b0a] - doc: add STYLE_GUIDE (moved from nodejs/docs) (Gibson Fahnestock) #113216abfcd560b] - doc: add comment for net.Server's error event (QianJin2013) #11136f4bc12dd11] - doc: note message event listeners ref IPC channels (Diego Rodríguez Baquero) #1149409c9105a79] - doc: argument types for assert methods (Amelia Clarke) #11548d622b67302] - doc: document clientRequest.aborted (Zach Bjornson) #11544d0dbf12884] - doc: update TheAlphaNerd to MylesBorins (Myles Borins) #1058605273c5a4e] - doc: update AUTHORS list to fix name (Noah Rose Ledesma) #1094579f700c891] - doc: add TimothyGu to collaborators (Timothy Gu) #10954e656a4244a] - doc: add edsadr to collaborators (Adrian Estrada) #108836d0e1621e5] - doc: clarifying variables in fs.write() (Jessica Quynh Tran) #97927287dddd69] - doc: add links for zlib convenience methods (Anna Henningsen) #10829b10842ac77] - doc: sort require statements in tests (Sam Roberts) #106168f0e31b2d9] - doc: add test naming information to guide (Rich Trott) #1058456b779db93] - doc: "s/git apply/git am -3" in V8 guide (Myles Borins) #106653be7a7adb5] - doc: update LTS info for current releases (Evan Lucas) #10720530adfdb2a] - doc: improve rinfo object documentation (Matt Crummey) #1005048b5097ea8] - http: make request.abort() destroy the socket (Luigi Pinca) #1081815231aa6e5] - http: reject control characters in http.request() (Ben Noordhuis) #8923fc2cd63998] - lib,src: support values > 4GB in heap statistics (Ben Noordhuis) #10186533d2bf0a9] - meta: add explicit deprecation and semver-major policy (James M Snell) #7964923309adef] - meta: remove Chris Dickinson from CTC (Chris Dickinson) #11267342c3e2bb4] - meta: adding Italo A. Casas PGP Fingerprint (Italo A. Casas) #11202434b00be8a] - meta: decharter the http working group (James M Snell) #10604a7df345921] - net: prefer === to == (Arseniy Maximov) #11513396688f075] - readline: refactor construct Interface (Jackson Tian) #4740a40f8429e6] - readline: update 6 comparions to strict (Umair Ishaq) #1107890d8e118fb] - src: add a missing space in node_os.cc (Alexey Orlenko) #10931279cb09cc3] - src: enable writev for pipe handles on Unix (Alexey Orlenko) #10677a557d6ce1d] - src: unconsume stream fix in internal http impl (Roee Kasher) #11015c4e1af712e] - src: remove unused typedef (Ben Noordhuis) #11322da2adb7133] - src: update http-parser link (Daniel Bevenius) #114772f48001574] - src: use ABORT() macro instead of abort() (Evan Lucas) #9613a9eb093ce3] - src: fix memory leak introduced in 34febfb (Ben Noordhuis) #9604f854d8c789] - test: increase setMulticastLoopback() coverage (cjihrig) #112771df09f9d37] - test: add known_issues test for Object.defineProperty on the global object does not handle 'writable' properly in vm context #10223 (AnnaMag) #11024be34b629de] - test: increase coverage for stream's duplex (abouthiroppy) #10963dc24127e5c] - test: allow for slow hosts in spawnSync() test (Rich Trott) #109982f4b6bda97] - test: expand test coverage of fs.js (Vinícius do Carmo) #109473f6a2dbc2f] - test: enhance test-timers (Rich Trott) #109606ca9901d8b] - test: add process.assert's test (abouthiroppy) #10911d8af5a7431] - test: improve code in test-crypto-verify (Adrian Estrada) #108454d1f7b1df8] - test: add dgram.Socket.prototype.bind's test (abouthiroppy) #108946c1d82c68a] - test: improving coverage for dgram (abouthiroppy) #10783017afd48fd] - test: improve code in test-console-instance (Adrian Estrada) #108131b1ba741c3] - test: improve code in test-domain-multi (Adrian Estrada) #10798ee27917a65] - test: improve test-stream2-large-read-stall (stefan judis) #107259ac2316595] - test: improve code in test-http-host-headers (Adrian Estrada) #10830a9278a063f] - test: refactor cluster-preload.js (abouthiroppy) #10701db60d92e15] - test: test hmac binding robustness (Sam Roberts) #10923a1a850f066] - test: don't connect to :: (use localhost instead) (Gibson Fahnestock)b3a8e95af3] - test: improve test-assert (richnologies) #1091656970efe51] - test: increase coverage for punycode's decode (abouthiroppy) #10940df69c2148a] - test: check fd 0,1,2 are used, not access mode (John Barboza) #103397bceb4fb48] - test: add message verification on assert.throws (Travis Meisenheimer) #108901c223ecc70] - test: add http-common's test (abouthiroppy) #1083289e9da6b6d] - test: tests for _readableStream.awaitDrain (Mark) #891453b0f413cd] - test: improve the code in test-process-cpuUsage (Adrian Estrada) #10714b3d1700d1f] - test: improve tests in pummel/test-exec (Chase Starr) #107576e7dfb1f45] - test: fix temp-dir option in tools/test.py (Gibson Fahnestock) #107239abde3ac6e] - test: use realpath for NODE_TEST_DIR in common.js (Gibson Fahnestock) #10723f86c64a13a] - test: refactor the code of test-keep-alive.js (sivaprasanna) #106844d51db87dc] - test: refactor test-doctool-html.js (abouthiroppy) #10696ab65429e44] - test: refactor test-watch-file.js (sivaprasanna) #106794453c0c1dc] - test: refactor the code in test-child-process-spawn-loop.js (sivaprasanna) #1060542b86ea968] - test: improve test-http-chunked-304 (Adrian Estrada) #104621ae95e64ee] - test: improve test-fs-readfile-zero-byte-liar (Adrian Estrada) #105703f3c78d785] - test: refactor test-fs-utimes (Junshu Okamoto) #929050a868b3f7] - test: require handler to be run in sigwinch test (Rich Trott) #11068c1f45ec2d0] - test: add 2nd argument to throws in test-assert (Marlena Compton) #11061f24aa7e071] - test: improve error messages in test-npm-install (Gonen Dukas) #110271db89d4009] - test: improve coverage on removeListeners functions (matsuda-koushi) #11140c532c16e53] - test: increase specificity in dgram test (Rich Trott) #11187cb81ae8eea] - test: add vm module edge cases (Franziska Hinkelmann) #112658629c956c3] - test: improve punycode test coverage (Sebastian Van Sande) #11144caf1ba15f9] - test: add coverage for dgram _createSocketHandle() (cjihrig) #11291d729e52ef3] - test: improve crypto coverage (Akito Ito) #11280d1a8588cab] - test: improve message in net-connect-local-error (Rich Trott) #11393f2fb4143b4] - test: refactor test-dgram-membership (Rich Trott) #11388bf4703d66f] - test: remove unused args and comparison fix (Alexander) #1139628471c23ff] - test: refactor test-http-response-splitting (Arseniy Maximov) #11429cd3e17e248] - test: improve coverage in test-crypto.dh (Eric Christie) #11253fa681ea55a] - test: add regex check to test-module-loading (Tarang Hirani) #11413f0eee61a93] - test: throw check in test-zlib-write-after-close (Jason Wilson) #11482f0c7c7fad4] - test: fix flaky test-vm-timeout-rethrow (Kunal Pathak) #1153053f2848dc8] - test: favor assertions over console logging (Rich Trott) #115470109321fd8] - test: refactor test-https-truncate (Rich Trott) #10225536733697c] - test: simplify test-http-client-unescaped-path (Rod Vagg) #96494ce9bfb4e7] - test: exclude pseudo-tty test pertinent to AIX CI failure: pseudo-tty/test-stderr-stdout-handle-sigwinch #11541 (Gireesh Punathil) #1160253dd1a8539] - tls: do not crash on STARTTLS when OCSP requested (Fedor Indutny) #10706e607ff52fa] - tools: rename eslintrc to an undeprecated format (Sakthipriyan Vairamani) #76996648b729b7] - tools: add compile_commands.json gyp generator (Ben Noordhuis) #79868f49962f47] - tools: suggest python2 command in configure (Roman Reiss) #113754b83a83c06] - tools,doc: add Google Analytics tracking. (Phillip Johnsen) #6601ef63af6006] - tty: avoid oob warning in TTYWrap::GetWindowSize() (Dmitry Tsvettsikh) #114542c84601062] - util: don't init Debug if it's not needed yet (Bryan English) #8452