Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: remove the invalid command line options #13764

Closed
wants to merge 1 commit into from
Closed

lib: remove the invalid command line options #13764

wants to merge 1 commit into from

Conversation

JacksonTian
Copy link
Contributor

@JacksonTian JacksonTian commented Jun 18, 2017 •
edited
Loading

The option --remote_debugging_server and --debug-agent are
not supported now.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

lib/internal/bootstrap_node

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Jun 18, 2017
@addaleax
Copy link
Member

LGTM but I’d combine this into #13763.

cjihrig
cjihrig approved these changes Jun 18, 2017
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on its own or as part of #13763

@JacksonTian JacksonTian changed the title lib: remove the useless entry for --debug-agent lib: remove the invalid entries Jun 19, 2017
@JacksonTian
Copy link
Contributor Author

Hi @addaleax @cjihrig I combined the two commits here.

cjihrig
cjihrig approved these changes Jun 19, 2017
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The commit message title should probably mention command line flags. It's not clear just from the title what "entries" are.

@JacksonTian JacksonTian changed the title lib: remove the invalid entries lib: remove the invalid command line options Jun 20, 2017
@JacksonTian
Copy link
Contributor Author

Updated the commit title.

@JacksonTian
lib: remove the invalid command line options
2c82fb0 
The option --remote_debugging_server and --debug-agent are
not supported now.
@BridgeAR
Copy link
Member

Landed in 9f175d1

@BridgeAR BridgeAR closed this Aug 30, 2017
BridgeAR pushed a commit that referenced this pull request Aug 30, 2017
@JacksonTian @BridgeAR
lib: remove the invalid command line options
9f175d1 
The option --remote_debugging_server and --debug-agent are
not supported now.

PR-URL: #13764
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@JacksonTian JacksonTian deleted the debug-agent branch August 31, 2017 06:57
cjihrig pushed a commit to cjihrig/node that referenced this pull request Aug 31, 2017
@JacksonTian @cjihrig
lib: remove the invalid command line options
cb7fb50 
The option --remote_debugging_server and --debug-agent are
not supported now.

PR-URL: nodejs#13764
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 5, 2017
@JacksonTian @addaleax
lib: remove the invalid command line options
6c94b81 
The option --remote_debugging_server and --debug-agent are
not supported now.

PR-URL: nodejs/node#13764
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@JacksonTian @MylesBorins
lib: remove the invalid command line options
2ba9ca2 
The option --remote_debugging_server and --debug-agent are
not supported now.

PR-URL: #13764
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@JacksonTian @MylesBorins
lib: remove the invalid command line options
ea0a882 
The option --remote_debugging_server and --debug-agent are
not supported now.

PR-URL: #13764
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@JacksonTian @addaleax @BridgeAR @jasnell @cjihrig @mhdawson @MylesBorins @nodejs-github-bot