Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: replace deprecated method #14450

Closed
wants to merge 1 commit into from
Closed

src: replace deprecated method #14450

wants to merge 1 commit into from

Conversation

fhinkel
Copy link
Member

@fhinkel fhinkel commented Jul 24, 2017

ForceSet() is marked to be deprecated. Replacing
it with DefineOwnProperty().

Checklist
Affected core subsystem(s)

src

@fhinkel fhinkel added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jul 24, 2017
@nodejs-github-bot nodejs-github-bot added async_wrap c++ Issues and PRs that require attention from people who are familiar with C++. labels Jul 24, 2017
@fhinkel fhinkel mentioned this pull request Jul 24, 2017
Closed
@ChALkeR
Copy link
Member

ChALkeR commented Jul 24, 2017 •
edited
Loading

Nit: src: replace deprecated ForceSet() method would be a bit more descriptive as the commit message title.

@fhinkel
src: replace deprecated ForceSet() method
ca1263d 
ForceSet() is marked to be deprecated. Replacing
it with DefineOwnProperty().
@fhinkel
Copy link
Member Author

fhinkel commented Jul 25, 2017

@ChALkeR good suggestion, changed it.

@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-commit/11386/

This is ready to be landed.

@addaleax
Copy link
Member

Landed in 85add2b

@addaleax addaleax closed this Jul 30, 2017
addaleax pushed a commit that referenced this pull request Jul 30, 2017
@fhinkel @addaleax
src: replace deprecated ForceSet() method
85add2b 
ForceSet() is marked to be deprecated. Replacing
it with DefineOwnProperty().

PR-URL: #14450
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
addaleax pushed a commit that referenced this pull request Aug 1, 2017
@fhinkel @addaleax
src: replace deprecated ForceSet() method
d90a5e0 
ForceSet() is marked to be deprecated. Replacing
it with DefineOwnProperty().

PR-URL: #14450
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@addaleax addaleax mentioned this pull request Aug 2, 2017
Merged
@MylesBorins MylesBorins added baking-for-lts PRs that need to wait before landing in a LTS release. lts-watch-v6.x labels Aug 16, 2017
@MylesBorins MylesBorins removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@fhinkel @ChALkeR @addaleax @jasnell @cjihrig @tniessen @MylesBorins @nodejs-github-bot