doc: various small revisions in url #14478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: 413691f "url: expose WHATWG url.origin as ASCII" Refs: nodejs#13126
nodejs-github-bot
added
doc
jasnell
approved these changes
Jul 25, 2017
| @@ -1150,3 +1156,5 @@ console.log(myURL.origin); | |||
| [examples of parsed URLs]: https://url.spec.whatwg.org/#example-url-parsing | |||
| [percent-encoded]: #whatwg-percent-encoding | |||
| [stable sorting algorithm]: https://en.wikipedia.org/wiki/Sorting_algorithm#Stability | |||
| [ICU]: intl.html#intl_options_for_building_node_js | |||
There was a problem hiding this comment.
It seems this and the next line are out of ASCII sorting order used for bottom references.
vsemozhetbyt
approved these changes
Jul 25, 2017
lpinca
approved these changes
Jul 25, 2017
cjihrig
approved these changes
Jul 26, 2017
tniessen
approved these changes
Jul 26, 2017
TimothyGu
added a commit
to TimothyGu/node
that referenced
this pull request
Jul 30, 2017
Fixes: 413691f "url: expose WHATWG url.origin as ASCII" PR-URL: nodejs#14478 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
TimothyGu
added a commit
to TimothyGu/node
that referenced
this pull request
Jul 30, 2017
PR-URL: nodejs#14478 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Aug 1, 2017
Fixes: 413691f "url: expose WHATWG url.origin as ASCII" PR-URL: #14478 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Aug 1, 2017
PR-URL: #14478 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc, url