test: http2 client destroy tests in one file #15749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
force-pushed
the
test-http2-client-destroy
branch
from
7fb7aef to
5978e53
Compare
|
Landed as d6031bc |
mcollina
pushed a commit
that referenced
this pull request
Oct 7, 2017
Refs: #14985 PR-URL: #15749 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
|
This is not landing cleanly on 8.x, can you please backport? |
trivikr
added a commit
to trivikr/node
that referenced
this pull request
Oct 7, 2017
Refs: nodejs#14985 PR-URL: nodejs#15749 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
|
@MylesBorins I've created backport PR at #16070 |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 7, 2017
Refs: #14985 Backport-PR-URL: #16070 PR-URL: #15749 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
|
land in 8ae4ae6 |
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
Refs: #14985 Backport-PR-URL: #16070 PR-URL: #15749 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
Refs: #14985 PR-URL: nodejs/node#15749 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes all client destroy tests in one file.
It also rearranges some statements and removes redundant ones in destroy()
Refs: #14985
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, http2