doc: add --abort-on-uncaught-exception + vm note

[cjihrig]

The --abort-on-uncaught-exception flag is not compatible with error handling involving the vm module. This is because V8 treats exceptions thrown from a VM as unhandled, and cause the process to abort. This commit adds a note to work around the issue using process.setUncaughtExceptionCaptureCallback().

Fixes: #13258

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

doc

[vsemozhetbyt]

Is this documented yet? I cannot find it in the last nightly docs:

https://nodejs.org/download/nightly/v10.0.0-nightly201711280fb1e07689/docs/api/process.html#process_process_setuncaughtexceptioncapturecallback_fn

[apapirovski]

It landed this morning so will need another night to pass :)

[vsemozhetbyt]

Sorry.

[addaleax]

Or wait. Maybe this should be an option on the vm.run*() methods? @cjihrig Do you think you’d prefer that? It should be pretty easy (or easy enough) to implement…

[cjihrig]

@addaleax I proposed that in #13258 (comment), but didn't really receive any feedback in favor. If you're on board, I could go that route.

If I were to implement it as an option, I'd probably just toggle the C++ flag when running the vm code, not take a user provided function.

[addaleax]

@cjihrig I was thinking an shouldAbortOnUncaughtException: boolean option on that object, not a function, with defaulting to false (or true and later flip to false if we’re worried about breakage). I’ll get a PR ready in a bit.