Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix max length on stream.md #19169

Closed
wants to merge 1 commit into from
Closed

doc: fix max length on stream.md #19169

wants to merge 1 commit into from

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Mar 6, 2018

See: #18438

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@mcollina mcollina added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 6, 2018
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Mar 6, 2018
@joyeecheung
Copy link
Member

Linter CI: https://ci.nodejs.org/job/node-test-pull-request-lite/225/

@mcollina
Copy link
Member Author

mcollina commented Mar 6, 2018

LINT CI: https://ci.nodejs.org/job/node-test-linter/16732/

@joyeecheung
Copy link
Member

CI is green

@mcollina
Copy link
Member Author

mcollina commented Mar 6, 2018

landing

@mcollina
Copy link
Member Author

mcollina commented Mar 6, 2018

Landed in 1a5ec83

@mcollina mcollina closed this Mar 6, 2018
@mcollina mcollina deleted the fix-markdown-linting-stream branch March 6, 2018 13:52
mcollina added a commit that referenced this pull request Mar 6, 2018
@mcollina
doc: fix max length on stream.md
1a5ec83 
See: #18438

PR-URL: #19169
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@mcollina @MayaLekova
doc: fix max length on stream.md
adc9ba4 
See: nodejs#18438

PR-URL: nodejs#19169
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcollina @joyeecheung @BridgeAR @nodejs-github-bot