doc: reword poolSize explanation in buffer.md #19785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original explanation was overly wordy, contained mildly questionable punctuation, and did not wrap at 80 characters. This rewording fixes all of these issues.
nodejs-github-bot
added
buffer
lpinca
approved these changes
Apr 4, 2018
vsemozhetbyt
added
the
fast-track
vsemozhetbyt
approved these changes
Apr 4, 2018
vsemozhetbyt
added
the
author ready
ChALkeR
approved these changes
Apr 4, 2018
trivikr
approved these changes
Apr 4, 2018
jasnell
approved these changes
Apr 4, 2018
|
@Trott - as we are here, does it make sense to accommodate the request from #19301 (comment) in this PR? |
gireeshpunathil
approved these changes
Apr 5, 2018
|
Landed in 3db0d62 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 6, 2018
The original explanation was overly wordy, contained mildly questionable punctuation, and did not wrap at 80 characters. This rewording fixes all of these issues. PR-URL: nodejs#19785 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 6, 2018
The original explanation was overly wordy, contained mildly questionable punctuation, and did not wrap at 80 characters. This rewording fixes all of these issues. PR-URL: #19785 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original explanation was overly wordy, contained mildly questionable
punctuation, and did not wrap at 80 characters. This rewording fixes all
of these issues.
Checklist