Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: added ready events to fs/streams,net/socket #19968

Closed
wants to merge 1 commit into from
Closed

doc: added ready events to fs/streams,net/socket #19968

wants to merge 1 commit into from

Conversation

towc
Copy link
Contributor

@towc towc commented Apr 12, 2018 •
edited by BridgeAR
Loading

Fixes: #19796

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 12, 2018
@towc
Copy link
Contributor Author

towc commented Apr 12, 2018

I ran some unwanted commands in the previous PR: #19935, which also accidentally closed it
I thought it would be cleaner to just make a new one

@towc towc mentioned this pull request Apr 12, 2018
Closed
3 tasks
mcollina
mcollina approved these changes Apr 12, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsemozhetbyt vsemozhetbyt added fs Issues and PRs related to the fs subsystem / file system. net Issues and PRs related to the net subsystem. labels Apr 12, 2018
@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 12, 2018
@BridgeAR
Copy link
Member

I added the Fixes: #19796 in the description, so the issue will be closed when landing this.

@BridgeAR
Copy link
Member

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite/502/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 12, 2018
@BridgeAR
Copy link
Member

Landed in e3f133a 🎉

@BridgeAR BridgeAR closed this Apr 12, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Apr 12, 2018
@towc @BridgeAR
doc: added ready events to fs/streams,net/socket
e3f133a 
PR-URL: nodejs#19968
Fixes: nodejs#19796
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 16, 2018
@towc @jasnell
doc: added ready events to fs/streams,net/socket
c29f2f2 
PR-URL: #19968
Fixes: #19796
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 1, 2018
@towc @BridgeAR
doc: added ready events to fs/streams,net/socket
eaf4a19 
PR-URL: nodejs#19968
Fixes: nodejs#19796
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fs,net: missing documentation for new "ready" events
6 participants
@towc @BridgeAR @mcollina @cjihrig @vsemozhetbyt @nodejs-github-bot