Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix two sorting nits in fs.md #20078

Closed
wants to merge 1 commit into from
Closed

doc: fix two sorting nits in fs.md #20078

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 16, 2018
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Apr 16, 2018
@vsemozhetbyt
Copy link
Contributor Author

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/535/

@vsemozhetbyt vsemozhetbyt mentioned this pull request Apr 16, 2018
Closed
@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 16, 2018
@vsemozhetbyt
Copy link
Contributor Author

Landed in 2e76b17

@vsemozhetbyt vsemozhetbyt deleted the doc-fs-sort branch April 16, 2018 16:21
vsemozhetbyt added a commit that referenced this pull request Apr 16, 2018
@vsemozhetbyt
doc: fix two sorting nits in fs.md
2e76b17 
PR-URL: #20078
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 16, 2018
@vsemozhetbyt @jasnell
doc: fix two sorting nits in fs.md
fc0ddaa 
PR-URL: #20078
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsemozhetbyt @lpinca @trivikr @nodejs-github-bot