Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: updating vs cpp build tool installation steps in building #24462

Closed
wants to merge 2 commits into from
Closed

doc: updating vs cpp build tool installation steps in building #24462

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf5034a
doc: updating the installation steps for the latest
krishnanandsivaraj Nov 18, 2018
9b14c79
doc: updating for better explanation
krishnanandsivaraj Nov 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions BUILDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,11 +385,12 @@ $ backtrace
Prerequisites:

krishnanandsivaraj marked this conversation as resolved.
Show resolved Hide resolved
* [Python 2.6 or 2.7](https://www.python.org/downloads/)
* The "Desktop development with C++" workload from
[Visual Studio 2017](https://www.visualstudio.com/downloads/) or the
refack marked this conversation as resolved.
Show resolved Hide resolved
"Visual C++ build tools" workload from the
* The "Build Tools for Visual Studio 2017" workload from the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to suggest an alternative for this whole bullet point:

[Visual Studio 2017](https://www.visualstudio.com/downloads/) or the	
[Build Tools for Visual Studio 2017](https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2017).
Installed with the "Visual C++ build tools" Workload,
and if available the "Git for Windows" and "Python 2 32-bit (2.7.x)" Individual
Components.

Based on these two screens:
image
and
image

Copy link
Member

@targos targos Nov 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me 👍
BTW do you know what the Node.js component adds?

Copy link
Contributor

@refack refack Nov 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW do you know what the Node.js component adds?

AFAIK it installs an LTS version (with our installer and it's defaults). Apropo that, it installs python with it's installer and it's defaults, which unfortunately do not include "Add to Path". So out-of-the-box it only works with the "Developer Command Prompt for VS 2017".

But as I showed before, even if you don't select it the node binary gets in there anyway (FTR I did not start any of those explicitly) 😜
image

Copy link
Contributor

@refack refack Nov 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two more
image

ping @joshgav @johnmont @AmandaSilver could you tell us what do the 4 above mentioned Node.js related components install, or please connect us with someone who can help?

P.S. the two in the screenshot and

  • Runtime for components based on Node.js v6.4.0 (x86)
  • Runtime for components based on Node.js v7.4.0 (x86)

[Build Tools](https://www.visualstudio.com/downloads/#build-tools-for-visual-studio-2017),
with the default optional components.
with the default optional components. Once the "Build Tools for Visual Studio
2017" downloaded, install it by choosing "Visual C++ build tools" from the
installer and proceed. It will install the necessary build tools to compile
the C++ files.
krishnanandsivaraj marked this conversation as resolved.
Show resolved Hide resolved
* Basic Unix tools required for some tests,
[Git for Windows](http://git-scm.com/download/win) includes Git Bash
and tools which can be included in the global `PATH`.
Expand Down