Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: misc cleanup II #25610

Closed
wants to merge 6 commits into from
Closed

report: misc cleanup II #25610

wants to merge 6 commits into from

Conversation

addaleax
Copy link
Member

The first commit is very whitespace-rich, so it’s worth using the ?w=1 variant of the diff.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
report: remove internalBinding('config').hasReport
da03f0f 
The `setup()` method is only called when the `--experimental-report`
option is set. `getOptionValue()` returns `undefined` when
the flag is not defined, so the extra check inside of `setup()` is
redundant.
@addaleax
src: remove unnecessary filename variable
768c1fd
@addaleax
report: roll extra loop iteration in PrintNativeStack()
7e0bed1
@addaleax
report: downgrade reinterpret_cast to static_cast
3130406
@addaleax
report: use uv_handle_type_name() to get handle type
ec5ee3e
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2317/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jan 21, 2019
cjihrig
cjihrig approved these changes Jan 21, 2019
View reviewed changes
src/node_report_utils.cc Outdated Show resolved Hide resolved
@addaleax
Copy link
Member Author

addaleax commented Jan 21, 2019 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/20231/ (:heavy_check_mark:)

@mscdex
Copy link
Contributor

mscdex commented Jan 21, 2019

FWIW here is a compiler warning I'm seeing in master if you want to include a fix for it as part of the cleanup:

../src/node_report.cc: In function ‘void report::PrintSystemInformation(report::JSONWriter*)’:
../src/node_report.cc:778:58: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 4 has type ‘rlim_t {aka long unsigned int}’ [-Wformat=]
         snprintf(buf, sizeof(buf), "%llu", limit.rlim_max);
                                            ~~~~~~~~~~~~~~^

@addaleax
Copy link
Member Author

@mscdex See #25597 (comment) for what I’d like to do/why this is isn’t included here :)

@addaleax addaleax added the report Issues and PRs related to process.report. label Jan 22, 2019
@addaleax
Copy link
Member Author

Maybe @lundibundi or @richardlau would be interested in reviewing this?

@richardlau
Copy link
Member

FWIW re. the Travis commit message linting failure -- I've raised nodejs/core-validate-commit#46 to add report as a valid subsystem.

@addaleax
Copy link
Member Author

Landed in f4697ba...5860614

@addaleax addaleax closed this Jan 24, 2019
@addaleax addaleax deleted the report-cleanup branch January 24, 2019 19:49
addaleax added a commit that referenced this pull request Jan 24, 2019
@addaleax
report: remove internalBinding('config').hasReport
3260a4a 
The `setup()` method is only called when the `--experimental-report`
option is set. `getOptionValue()` returns `undefined` when
the flag is not defined, so the extra check inside of `setup()` is
redundant.

PR-URL: #25610
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
addaleax added a commit that referenced this pull request Jan 24, 2019
@addaleax
src: remove unnecessary filename variable
97f6261 
PR-URL: #25610
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
addaleax added a commit that referenced this pull request Jan 24, 2019
@addaleax
report: roll extra loop iteration in PrintNativeStack()
6545197 
PR-URL: #25610
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
addaleax added a commit that referenced this pull request Jan 24, 2019
@addaleax
report: downgrade reinterpret_cast to static_cast
69ce113 
PR-URL: #25610
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
addaleax added a commit that referenced this pull request Jan 24, 2019
@addaleax
report: use uv_handle_type_name() to get handle type
5860614 
PR-URL: #25610
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@MylesBorins
Copy link
Contributor

Should this be backported to v11.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

addaleax added a commit that referenced this pull request Jan 24, 2019
@addaleax
report: remove internalBinding('config').hasReport
64959b6 
The `setup()` method is only called when the `--experimental-report`
option is set. `getOptionValue()` returns `undefined` when
the flag is not defined, so the extra check inside of `setup()` is
redundant.

PR-URL: #25610
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
addaleax added a commit that referenced this pull request Jan 24, 2019
@addaleax
src: remove unnecessary filename variable
a161a9b 
PR-URL: #25610
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
addaleax added a commit that referenced this pull request Jan 24, 2019
@addaleax
report: roll extra loop iteration in PrintNativeStack()
07a0dc8 
PR-URL: #25610
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
addaleax added a commit that referenced this pull request Jan 24, 2019
@addaleax
report: downgrade reinterpret_cast to static_cast
03ba344 
PR-URL: #25610
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
addaleax added a commit that referenced this pull request Jan 24, 2019
@addaleax
report: use uv_handle_type_name() to get handle type
f3d0591 
PR-URL: #25610
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil Awaiting requested review from gireeshpunathil

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. report Issues and PRs related to process.report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@addaleax @nodejs-github-bot @mscdex @richardlau @MylesBorins @cjihrig